From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbbCII3c (ORCPT ); Mon, 9 Mar 2015 04:29:32 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:42378 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbbCII33 convert rfc822-to-8bit (ORCPT ); Mon, 9 Mar 2015 04:29:29 -0400 From: Alexey Brodkin To: "wsa@the-dreams.de" CC: "mika.westerberg@linux.intel.com" , "linux-kernel@vger.kernel.org" , "Vineet.Gupta1@synopsys.com" , "andriy.shevchenko@linux.intel.com" , "christian.ruppert@alitech.com" , "linux-i2c@vger.kernel.org" , "christian.ruppert@abilis.com" Subject: Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER Thread-Topic: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER Thread-Index: AQHQVcabDW0JFlhjCk25ck2c0gJuOJ0K4ckAgAAClACABTmPAIADrA8A Date: Mon, 9 Mar 2015 08:29:24 +0000 Message-ID: <1425889764.5234.13.camel@synopsys.com> References: <1425396456-10633-1-git-send-email-abrodkin@synopsys.com> <54F5E120.3090705@alitech.com> <1425400650.17965.53.camel@synopsys.com> <20150307002447.GE993@katana> In-Reply-To: <20150307002447.GE993@katana> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.225.15.34] Content-Type: text/plain; charset="utf-7" Content-ID: <447ECB29E691F14498D8DEDD7439B3BF@internal.synopsys.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On Sat, 2015-03-07 at 01:24 +-0100, Wolfram Sang wrote: +AD4- +AD4- +AD4- Presented like this I wonder if this merits being a dev+AF8-err at all. +AD4- +AD4- +AD4- Wouldn't dev+AF8-dbg be more adequate? This might remove the need for the +AD4- +AD4- +AD4- condition and also avoid bothering everyone if something in the platform +AD4- +AD4- +AD4- device structures or device tree is not right. +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- return irq+ADs- /+ACo- -ENXIO +ACo-/ +AD4- +AD4- +AD4- +AD4- +AH0- +AD4- +AD4- +AD4- +AD4- We've just had similar discussion related to DW APB UART with Andy here +AD4- +AD4- https://lkml.org/lkml/2015/3/3/412 +AD4- +AD4- +AD4- +AD4- So yes probably we may safely remove error message from here completely. +AD4- +AD4- So, do you want to send a V2? Sorry for this delay - I was away for last few days. I'm about to send v2 with removal of error message completely. -Alexey