From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932390AbbCIQ0N (ORCPT ); Mon, 9 Mar 2015 12:26:13 -0400 Received: from smtprelay0164.hostedemail.com ([216.40.44.164]:54922 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753605AbbCIQ0K (ORCPT ); Mon, 9 Mar 2015 12:26:10 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3866:4321:5007:6114:6261:6642:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12291:12296:12438:12517:12519:12533:12555:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: tooth99_358e425397d39 X-Filterd-Recvd-Size: 1965 Message-ID: <1425918067.5428.10.camel@perches.com> Subject: Re: [PATCH v6 06/16] h8300: CPU depend helpers From: Joe Perches To: Yoshinori Sato Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org In-Reply-To: <1425890830-29399-7-git-send-email-ysato@users.sourceforge.jp> References: <1425890830-29399-1-git-send-email-ysato@users.sourceforge.jp> <1425890830-29399-7-git-send-email-ysato@users.sourceforge.jp> Content-Type: text/plain; charset="ISO-8859-1" Date: Mon, 09 Mar 2015 09:21:07 -0700 Mime-Version: 1.0 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-09 at 17:47 +0900, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato trivia: > arch/h8300/kernel/cpu/h83069/setup.c | 202 ++++++++++++++++++++++++++ [] > diff --git a/arch/h8300/kernel/cpu/h83069/setup.c b/arch/h8300/kernel/cpu/h83069/setup.c [] > +static struct resource sci0_resources[] = { > + DEFINE_RES_MEM(0xffffb0, 8), > + DEFINE_RES_IRQ(52), > + DEFINE_RES_IRQ(53), > + DEFINE_RES_IRQ(54), > + DEFINE_RES_IRQ(55), > +} Perhaps most all of these might be const? > +static struct plat_sci_port sci0_platform_data = { [] > +static struct resource sci1_resources[] = { [] > +static struct plat_sci_port sci1_platform_data = { [] > +static struct platform_device sci0_device = { [] > +static struct platform_device sci1_device = { [] > +static struct h8300_timer8_config tm8_unit0_platform_data = { [] > +static struct resource tm8_unit0_resources[] = { [] > +static struct platform_device timer8_unit0_device = { [] > +static struct h8300_timer8_config tm8_unit1_platform_data = { [] etc..