From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753357AbbCJT0P (ORCPT ); Tue, 10 Mar 2015 15:26:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34871 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbbCJT0N (ORCPT ); Tue, 10 Mar 2015 15:26:13 -0400 Message-ID: <1426015564.2055.2.camel@stgolabs.net> Subject: Re: [patch v3] mm, hugetlb: abort __get_user_pages if current has been oom killed From: Davidlohr Bueso To: David Rientjes Cc: Andrew Morton , Greg Thelen , Naoya Horiguchi , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Date: Tue, 10 Mar 2015 12:26:04 -0700 In-Reply-To: References: <20150309043051.GA13380@node.dhcp.inet.fi> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-09 at 13:07 -0700, David Rientjes wrote: > If __get_user_pages() is faulting a significant number of hugetlb pages, > usually as the result of mmap(MAP_LOCKED), it can potentially allocate a > very large amount of memory. > > If the process has been oom killed, this will cause a lot of memory to > potentially deplete memory reserves. > > In the same way that commit 4779280d1ea4 ("mm: make get_user_pages() > interruptible") aborted for pending SIGKILLs when faulting non-hugetlb > memory, based on the premise of commit 462e00cc7151 ("oom: stop > allocating user memory if TIF_MEMDIE is set"), hugetlb page faults now > terminate when the process has been oom killed. > > Cc: Greg Thelen > Cc: Naoya Horiguchi > Cc: Davidlohr Bueso > Acked-by: "Kirill A. Shutemov" > Signed-off-by: David Rientjes Makes sense. Acked-by: Davidlohr Bueso