From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751367AbbCKLnN (ORCPT ); Wed, 11 Mar 2015 07:43:13 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:46510 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbbCKLnJ (ORCPT ); Wed, 11 Mar 2015 07:43:09 -0400 Message-ID: <1426074142.30734.7.camel@pengutronix.de> Subject: Re: [PATCH v2 3/4] cpufreq: mediatek: add Mediatek cpufreq driver From: Lucas Stach To: Viresh Kumar Cc: Mark Brown , Mark Rutland , Catalin Marinas , Chen Fan , Ian Campbell , Howard Chen , "Joe.C" , "devicetree@vger.kernel.org" , Linaro Kernel Mailman List , Pawel Moll , "linux-pm@vger.kernel.org" , Sascha Hauer , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Eddie Huang , "linux-arm-kernel@lists.infradead.org" , Thomas Petazzoni , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kumar Gala Date: Wed, 11 Mar 2015 12:42:22 +0100 In-Reply-To: References: <1425458956-20665-1-git-send-email-pi-cheng.chen@linaro.org> <1425458956-20665-4-git-send-email-pi-cheng.chen@linaro.org> <20150311105307.GW28806@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:fa0f:41ff:fe58:4010 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, den 11.03.2015, 16:33 +0530 schrieb Viresh Kumar: > On 11 March 2015 at 16:23, Mark Brown wrote: > > On Tue, Mar 10, 2015 at 08:20:43AM +0530, Viresh Kumar wrote: > > > > Please don't send upstream e-mail to my work account, I use this address > > pretty consistently for upstream. Upstream mail to my work account > > frequently ends up unread. > > Sorry about that, I did exactly opposite of this earlier :( > > >> On 6 March 2015 at 11:19, Pi-Cheng Chen wrote: > >> > On 5 March 2015 at 17:55, Viresh Kumar wrote: > > > >> > About putting > >> > those stuff into regulator driver, I think you mean creating a > >> > "virtual regulator > >> > device" and put all the voltage controlling complex into the driver, right? > >> > Maybe it's a good idea in this case, but I am sure if this kind of > >> > virtual regulator is acceptable. > > > >> @Mark: Is this allowed to create virtual regulator for a CPU ? > > > > I don't really know what the above means or what problem it's supposed > > to solve. > > On mediatek platform, they need to configure two regulators in order to change > DVFS state of the big cluster. The generic cpufreq-dt driver and earlier OPP > bindings have support for a single regulator only and so what Pi-cheng tried > to do is, > - Configure one of the regulators using cpufreq-dt > - And other one using cpufreq frequency change notifiers > > This looks awkward.. > > What I suggested was to create another virtual regulator for CPU which will > eventually configure both the regulators. And so the question that such > virtual regulators are allowed or not. Instead of creating virtual regulators I would be strongly in favor of reviving the voltage-domain work. That would allow us to push all those voltage dependencies we have seen on various SoCs into the domain handling code and don't care about it in the drivers. In that case cpufreq-dt wouldn't control a regulator directly, but request a specific voltage from the domain the CPUs are located in and those in turn would control the regulators supplying them. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |