From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756611AbbCNBNg (ORCPT ); Fri, 13 Mar 2015 21:13:36 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35184 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755881AbbCNBNc (ORCPT ); Fri, 13 Mar 2015 21:13:32 -0400 From: Akinobu Mita To: linux-kernel@vger.kernel.org Cc: Akinobu Mita , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org Subject: [PATCH] ia64: Use bitmap_weight Date: Sat, 14 Mar 2015 10:12:57 +0900 Message-Id: <1426295577-10836-5-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1426295577-10836-1-git-send-email-akinobu.mita@gmail.com> References: <1426295577-10836-1-git-send-email-akinobu.mita@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use bitmap_weight to count the total number of bits set in bitmap. This change just simplifies the code a bit. Signed-off-by: Akinobu Mita Cc: Tony Luck Cc: Fenghua Yu Cc: linux-ia64@vger.kernel.org --- arch/ia64/hp/common/sba_iommu.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/arch/ia64/hp/common/sba_iommu.c b/arch/ia64/hp/common/sba_iommu.c index 344387a..9c944fa 100644 --- a/arch/ia64/hp/common/sba_iommu.c +++ b/arch/ia64/hp/common/sba_iommu.c @@ -33,7 +33,7 @@ #include #include #include -#include /* hweight64() */ +#include /* bitmap_weight() */ #include #include #include @@ -1901,8 +1901,7 @@ static int ioc_show(struct seq_file *s, void *v) { struct ioc *ioc = v; - unsigned long *res_ptr = (unsigned long *)ioc->res_map; - int i, used = 0; + int used; seq_printf(s, "Hewlett Packard %s IOC rev %d.%d\n", ioc->name, ((ioc->rev >> 4) & 0xF), (ioc->rev & 0xF)); @@ -1913,8 +1912,8 @@ ioc_show(struct seq_file *s, void *v) seq_printf(s, "IOVA size : %ld MB\n", ((ioc->pdir_size >> 3) * iovp_size)/(1024*1024)); seq_printf(s, "IOVA page size : %ld kb\n", iovp_size/1024); - for (i = 0; i < (ioc->res_size / sizeof(unsigned long)); ++i, ++res_ptr) - used += hweight64(*res_ptr); + used = bitmap_weight((unsigned long *)ioc->res_map, + ioc->res_size * BITS_PER_BYTE); seq_printf(s, "PDIR size : %d entries\n", ioc->pdir_size >> 3); seq_printf(s, "PDIR used : %d entries\n", used); -- 1.9.1