From: "M. Vefa Bicakci" <m.v.b@runbox.com>
To: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Cc: joe@perches.com, Larry.Finger@lwfinger.net,
gregkh@linuxfoundation.org, Jes.Sorensen@redhat.com,
m.v.b@runbox.com
Subject: [PATCH v2 09/16] staging: rtl8723au: trailing statements should be on next line
Date: Sat, 14 Mar 2015 20:10:34 -0400 [thread overview]
Message-ID: <1426378241-32469-10-git-send-email-m.v.b@runbox.com> (raw)
In-Reply-To: <1426378241-32469-1-git-send-email-m.v.b@runbox.com>
Correct a number of checkpatch.pl errors in rtl8723au's rtw_security.c
related to trailing statements:
ERROR: trailing statements should be on next line
Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
---
drivers/staging/rtl8723au/core/rtw_security.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c
index b4327aaf71..803f8965a4 100644
--- a/drivers/staging/rtl8723au/core/rtw_security.c
+++ b/drivers/staging/rtl8723au/core/rtw_security.c
@@ -132,7 +132,8 @@ static u32 getcrc32(u8 *buf, int len)
u8 *p;
u32 crc;
- if (bcrc32initialized == 0) crc32_init();
+ if (bcrc32initialized == 0)
+ crc32_init();
crc = 0xffffffff; /* preload shift register, per CRC-32 spec */
@@ -559,8 +560,10 @@ static void phase2(u8 *rc4key, const u8 *tk, const u16 *p1k, u16 iv16)
u16 PPK[6]; /* temporary key for mixing */
/* Note: all adds in the PPK[] equations below are mod 2**16 */
- for (i = 0; i < 5; i++) PPK[i] = p1k[i]; /* first, copy P1K to PPK */
- PPK[5] = p1k[4] + iv16; /* next, add in IV16 */
+ for (i = 0; i < 5; i++)
+ PPK[i] = p1k[i]; /* first, copy P1K to PPK */
+
+ PPK[5] = p1k[4] + iv16; /* next, add in IV16 */
/* Bijective non-linear mixing of the 96 bits of PPK[0..5] */
PPK[0] += _S_(PPK[5] ^ TK16(0)); /* Mix key in each "round" */
@@ -960,7 +963,8 @@ static void aes128k128d(u8 *key, u8 *data, u8 *ciphertext)
u8 intermediateb[16];
u8 round_key[16];
- for (i = 0; i < 16; i++) round_key[i] = key[i];
+ for (i = 0; i < 16; i++)
+ round_key[i] = key[i];
for (round = 0; round < 11; round++) {
if (round == 0) {
@@ -1044,7 +1048,8 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, int a4_exists,
{
int i;
- for (i = 0; i < 16; i++) mic_header2[i] = 0x00;
+ for (i = 0; i < 16; i++)
+ mic_header2[i] = 0x00;
mic_header2[0] = mpdu[16]; /* A3 */
mic_header2[1] = mpdu[17];
@@ -1057,7 +1062,8 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, int a4_exists,
mic_header2[7] = 0x00; /* mpdu[23]; */
if (!qc_exists && a4_exists) {
- for (i = 0; i < 6; i++) mic_header2[8+i] = mpdu[24+i]; /* A4 */
+ for (i = 0; i < 6; i++)
+ mic_header2[8+i] = mpdu[24+i]; /* A4 */
}
if (qc_exists && !a4_exists) {
@@ -1066,7 +1072,8 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, int a4_exists,
}
if (qc_exists && a4_exists) {
- for (i = 0; i < 6; i++) mic_header2[8+i] = mpdu[24+i]; /* A4 */
+ for (i = 0; i < 6; i++)
+ mic_header2[8+i] = mpdu[24+i]; /* A4 */
mic_header2[14] = mpdu[30] & 0x0f;
mic_header2[15] = mpdu[31] & 0x00;
@@ -1084,7 +1091,9 @@ static void construct_ctr_preload(u8 *ctr_preload, int a4_exists, int qc_exists,
{
int i = 0;
- for (i = 0; i < 16; i++) ctr_preload[i] = 0x00;
+ for (i = 0; i < 16; i++)
+ ctr_preload[i] = 0x00;
+
i = 0;
ctr_preload[0] = 0x01; /* flag */
--
2.1.4
next prev parent reply other threads:[~2015-03-15 0:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 0:10 [PATCH v2 00/16] checkpatch clean-up of rtl8723au's rtw_security.c M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 01/16] staging: rtl8723au: Reformat whitespace to increase readability M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 02/16] staging: rtl8723au: Fix "before/around/after" whitespace issues M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 03/16] staging: rtl8723au: else should follow close brace M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 04/16] staging: rtl8723au: Fix the indentation of two lines M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 05/16] staging: rtl8723au: Reorganize a few functions to remove indentation M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 06/16] staging: rtl8723au: Do not initialize a static to 0 M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 07/16] staging: rtl8723au: else is not generally useful after a return M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 08/16] staging: rtl8723au: Remove unneeded curly braces M. Vefa Bicakci
2015-03-15 0:10 ` M. Vefa Bicakci [this message]
2015-03-15 0:10 ` [PATCH v2 10/16] staging: rtl8723au: that open brace should be on the previous line M. Vefa Bicakci
2015-03-16 16:36 ` Jes Sorensen
2015-03-15 0:10 ` [PATCH v2 11/16] staging: rtl8723au: No spaces at the start of a line M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 12/16] staging: rtl8723au: Adjust whitespace in and around comments M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 13/16] staging: rtl8723au: suspect code indent for conditional statements M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 14/16] staging: rtl8723au: Rework two byte array comparisons M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 15/16] staging: rtl8723au: Correct a typo in a trace log line M. Vefa Bicakci
2015-03-16 16:38 ` Jes Sorensen
2015-03-15 0:10 ` [PATCH v2 16/16] staging: rtl8723au: Remove unneeded comments M. Vefa Bicakci
2015-03-15 9:31 ` [PATCH v2 00/16] checkpatch clean-up of rtl8723au's rtw_security.c Matthias Beyer
2015-03-15 13:51 ` M. Vefa Bicakci
2015-03-16 16:01 ` Jes Sorensen
2015-03-16 16:55 ` Joe Perches
2015-03-16 17:07 ` Greg KH
2015-03-16 17:11 ` Joe Perches
2015-03-19 4:34 ` M. Vefa Bicakci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426378241-32469-10-git-send-email-m.v.b@runbox.com \
--to=m.v.b@runbox.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).