From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753226AbbCPCsw (ORCPT ); Sun, 15 Mar 2015 22:48:52 -0400 Received: from ozlabs.org ([103.22.144.67]:38604 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbbCPCsu (ORCPT ); Sun, 15 Mar 2015 22:48:50 -0400 Message-ID: <1426474128.20210.2.camel@ellerman.id.au> Subject: Re: [PATCH 2/2] selftests/timers: change to use shared logic to run and install tests From: Michael Ellerman To: John Stultz Cc: Shuah Khan , Thomas Gleixner , Linux API , lkml Date: Mon, 16 Mar 2015 13:48:48 +1100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-13 at 20:14 -0700, John Stultz wrote: > On Fri, Mar 13, 2015 at 3:57 PM, Shuah Khan wrote: > > Change the timers Makefile to make use of shared run and install > > logic in lib.mk. Destructive tests are installed. Regular tests > > are emited to run_kselftest script to match the run_tests behavior. > > > > Signed-off-by: Shuah Khan > > --- > > tools/testing/selftests/timers/Makefile | 20 +++++++++++--------- > > 1 file changed, 11 insertions(+), 9 deletions(-) > > > > diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile > > index 9da3498..61e7284 100644 > > --- a/tools/testing/selftests/timers/Makefile > > +++ b/tools/testing/selftests/timers/Makefile > > @@ -7,19 +7,21 @@ bins = posix_timers nanosleep inconsistency-check nsleep-lat raw_skew \ > > alarmtimer-suspend change_skew skew_consistency clocksource-switch \ > > leap-a-day leapcrash set-tai set-2038 > > > > +TEST_PROGS = posix_timers nanosleep nsleep-lat set-timer-lat mqueue-lat \ > > + inconsistency-check raw_skew > > +TEST_FILES = threadtest alarmtimer-suspend valid-adjtimex change_skew \ > > + skew_consistency clocksource-switch leap-a-day leapcrash \ > > + set-tai set-2038 > > + > > +RUN_TESTS_WITH_ARGS := ./threadtest -t 30 -n 8 || echo "selftests: threadtest [FAIL]" > > + > > +EMIT_TESTS_WITH_ARGS := echo "$(RUN_TESTS_WITH_ARGS)" > > + > > So my make-foo isn't very strong, but no objections from me. > > My only thoughts: > 1) Would it be better if threadtest can be made to have better > defaults for kselftest so you don't need that extra logic? That would help. But with the patch I just sent I think it's no bother, it's only a little extra logic and it's only in the timers Makefile. > 2) While I get that TEST_FILES is likely going to be used to copy the > destructive tests over, It feels a little like its being bundled in > with something like data files that tests might need, which seems sort > of hackish. Would TEST_PROGS_EXTENDED or something be more clear and > make more sense? That doesn't really bother me. You're right that TEST_FILES is originally intended for data files etc. but I don't think it's a big hack to use it for other tests that shouldn't be run by default. Still if it bothers you I'm happy to add a separate variable for it, they are cheap :) cheers