From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752546AbbCXMIj (ORCPT ); Tue, 24 Mar 2015 08:08:39 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:44471 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752194AbbCXMIe (ORCPT ); Tue, 24 Mar 2015 08:08:34 -0400 From: Markus Pargmann To: Mark Brown Cc: Liam Girdwood , Wolfram Sang , kernel@pengutronix.de, linux-kernel@vger.kernel.org, Markus Pargmann Subject: [PATCH 2/2] regulator: max8660: Add error message for missing regulator data Date: Tue, 24 Mar 2015 13:08:03 +0100 Message-Id: <1427198883-6577-2-git-send-email-mpa@pengutronix.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1427198883-6577-1-git-send-email-mpa@pengutronix.de> References: <1427198883-6577-1-git-send-email-mpa@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver probe fails when there is a subdevice without platform_data. Add a error message so it is clear what failed. Signed-off-by: Markus Pargmann --- drivers/regulator/max8660.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/max8660.c b/drivers/regulator/max8660.c index 32cf277a7662..b1ba1d09e064 100644 --- a/drivers/regulator/max8660.c +++ b/drivers/regulator/max8660.c @@ -441,8 +441,10 @@ static int max8660_probe(struct i2c_client *client, max8660->shadow_regs[MAX8660_MDTV2] = 0x04; for (i = 0; i < pdata->num_subdevs; i++) { - if (!pdata->subdevs[i].platform_data) + if (!pdata->subdevs[i].platform_data) { + dev_err(dev, "No data for %d regulator\n", i); return -EINVAL; + } switch (pdata->subdevs[i].id) { case MAX8660_V3: -- 2.1.4