From: Jason Low <jason.low2@hp.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Christoph Lameter <cl@linux.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Aswin Chandramouleeswaran <aswin@hp.com>,
Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>,
Minchan Kim <minchan@kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Rik van Riel <riel@redhat.com>,
jason.low2@hp.com
Subject: Re: [PATCH] mm: Remove usages of ACCESS_ONCE
Date: Tue, 24 Mar 2015 09:58:32 -0700 [thread overview]
Message-ID: <1427216312.2515.46.camel@j-VirtualBox> (raw)
In-Reply-To: <551177F0.3070006@de.ibm.com>
On Tue, 2015-03-24 at 15:42 +0100, Christian Borntraeger wrote:
> Am 23.03.2015 um 23:44 schrieb Jason Low:
> > Commit 38c5ce936a08 converted ACCESS_ONCE usage in gup_pmd_range() to
> > READ_ONCE, since ACCESS_ONCE doesn't work reliably on non-scalar types.
> >
> > This patch removes the rest of the usages of ACCESS_ONCE, and use
> > READ_ONCE for the read accesses. This also makes things cleaner,
> > instead of using separate/multiple sets of APIs.
> >
> > Signed-off-by: Jason Low <jason.low2@hp.com>
>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Thanks.
> one remark or question:
>
> > - anon_mapping = (unsigned long) ACCESS_ONCE(page->mapping);
> > + anon_mapping = (unsigned long)READ_ONCE(page->mapping);
>
> Were the white space changes intentional? IIRC checkpatch does prefer
> it your way and you have changed several places - so I assume yes.
Yeah, those changes were intentional.
I thought that this was more of the standard style to do casting, so I
made those changes as well.
> Either way, its probably fine to change that along.
Okay, I'll assume that this is fine for now unless something thinks this
shouldn't be part of the patch.
prev parent reply other threads:[~2015-03-24 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 22:44 [PATCH] mm: Remove usages of ACCESS_ONCE Jason Low
2015-03-24 10:30 ` Michal Hocko
2015-03-24 18:30 ` Jason Low
2015-03-25 7:51 ` Michal Hocko
2015-03-24 14:32 ` Davidlohr Bueso
2015-03-24 14:39 ` Rik van Riel
2015-03-24 14:42 ` Christian Borntraeger
2015-03-24 16:58 ` Jason Low [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427216312.2515.46.camel@j-VirtualBox \
--to=jason.low2@hp.com \
--cc=akpm@linux-foundation.org \
--cc=aswin@hp.com \
--cc=borntraeger@de.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=dave@stgolabs.net \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).