From: Jason Low <jason.low2@hp.com>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: peterz@infradead.org, mingo@kernel.org, riel@redhat.com,
daniel.lezcano@linaro.org, vincent.guittot@linaro.org,
srikar@linux.vnet.ibm.com, pjt@google.com,
benh@kernel.crashing.org, efault@gmx.de,
linux-kernel@vger.kernel.org, iamjoonsoo.kim@lge.com,
svaidy@linux.vnet.ibm.com, tim.c.chen@linux.intel.com,
morten.rasmussen@arm.com, jason.low2@hp.com
Subject: Re: [PATCH V2] sched: Improve load balancing in the presence of idle CPUs
Date: Thu, 26 Mar 2015 10:03:20 -0700 [thread overview]
Message-ID: <1427389400.2777.3.camel@j-VirtualBox> (raw)
In-Reply-To: <20150326130014.21532.17158.stgit@preeti.in.ibm.com>
On Thu, 2015-03-26 at 18:32 +0530, Preeti U Murthy wrote:
> kernel/sched/fair.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index bcfe320..8b6d0d5 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -7660,14 +7660,16 @@ static void run_rebalance_domains(struct softirq_action *h)
> enum cpu_idle_type idle = this_rq->idle_balance ?
> CPU_IDLE : CPU_NOT_IDLE;
>
> - rebalance_domains(this_rq, idle);
> -
> /*
> * If this cpu has a pending nohz_balance_kick, then do the
> * balancing on behalf of the other idle cpus whose ticks are
> - * stopped.
> + * stopped. Do nohz_idle_balance *before* rebalance_domains to
> + * give the idle cpus a chance to load balance. Else we may
> + * load balance only within the local sched_domain hierarchy
> + * and abort nohz_idle_balance altogether if we pull some load.
> */
> nohz_idle_balance(this_rq, idle);
> + rebalance_domains(this_rq, idle);
Reviewed-by: Jason Low <jason.low2@hp.com>
next prev parent reply other threads:[~2015-03-26 17:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 13:02 [PATCH V2] sched: Improve load balancing in the presence of idle CPUs Preeti U Murthy
2015-03-26 17:03 ` Jason Low [this message]
2015-03-27 2:12 ` Wanpeng Li
2015-03-27 4:33 ` Preeti U Murthy
2015-03-27 4:23 ` Wanpeng Li
2015-03-27 5:01 ` Jason Low
2015-03-27 5:07 ` Jason Low
2015-03-27 5:39 ` Srikar Dronamraju
2015-03-27 7:00 ` Wanpeng Li
2015-03-27 6:43 ` Wanpeng Li
2015-03-27 16:23 ` Preeti U Murthy
2015-03-27 11:43 ` [tip:sched/core] " tip-bot for Preeti U Murthy
2015-03-27 13:03 ` [PATCH V2] " Srikar Dronamraju
2015-03-27 14:38 ` Morten Rasmussen
2015-03-27 16:46 ` Preeti U Murthy
2015-03-27 17:56 ` Morten Rasmussen
2015-03-30 7:26 ` Preeti U Murthy
2015-03-30 11:30 ` Morten Rasmussen
2015-03-30 11:06 ` Peter Zijlstra
2015-03-30 12:03 ` Morten Rasmussen
2015-03-30 12:24 ` Peter Zijlstra
2015-03-30 12:54 ` Peter Zijlstra
2015-03-30 13:29 ` Vincent Guittot
2015-03-30 14:01 ` Peter Zijlstra
2015-03-30 15:27 ` Morten Rasmussen
2015-03-31 8:58 ` Preeti U Murthy
2015-03-31 17:30 ` Jason Low
2015-04-01 6:28 ` Preeti U Murthy
2015-04-01 13:03 ` Morten Rasmussen
2015-04-02 0:55 ` Jason Low
2015-04-02 3:22 ` Preeti U Murthy
2015-03-30 13:45 ` Vincent Guittot
2015-03-31 8:06 ` Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427389400.2777.3.camel@j-VirtualBox \
--to=jason.low2@hp.com \
--cc=benh@kernel.crashing.org \
--cc=daniel.lezcano@linaro.org \
--cc=efault@gmx.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).