From: Scott Branden <sbranden@broadcom.com>
To: Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>
Cc: <bcm-kernel-feedback-list@broadcom.com>,
Dmitry Torokhov <dtor@google.com>,
Anatol Pomazao <anatol@google.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
ismail <ismail@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Subject: [PATCH] dmaengine: pl330: fix the race condition in pl330 driver.
Date: Thu, 26 Mar 2015 16:55:05 -0700 [thread overview]
Message-ID: <1427414105-3480-1-git-send-email-sbranden@broadcom.com> (raw)
From: ismail <ismail@broadcom.com>
Update the thread running index before issuing the
GO command to the DMAC.
Tested-by: Mohamed Ismail Abdul Packir Mohamed <ismail@broadcom.com>
Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Arun Parameswaran <aparames@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Mohamed Ismail Abdul Packir Mohamed <ismail@broadcom.com>
---
drivers/dma/pl330.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 0e1f567..631642d 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -1072,11 +1072,11 @@ static bool _trigger(struct pl330_thread *thrd)
/* Set to generate interrupts for SEV */
writel(readl(regs + INTEN) | (1 << thrd->ev), regs + INTEN);
+ thrd->req_running = idx;
+
/* Only manager can execute GO */
_execute_DBGINSN(thrd, insn, true);
- thrd->req_running = idx;
-
return true;
}
--
2.3.3
next reply other threads:[~2015-03-26 23:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 23:55 Scott Branden [this message]
2015-03-29 21:55 ` [PATCH] dmaengine: pl330: fix the race condition in pl330 driver Scott Branden
2015-03-30 16:47 ` Jassi Brar
2015-03-30 17:25 ` Vinod Koul
2015-03-31 3:40 ` Scott Branden
2015-03-31 5:20 ` Jassi Brar
2015-03-31 22:04 ` Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427414105-3480-1-git-send-email-sbranden@broadcom.com \
--to=sbranden@broadcom.com \
--cc=anatol@google.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.j.williams@intel.com \
--cc=dtor@google.com \
--cc=ismail@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).