linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vinod.koul@intel.com>, <linux@arm.linux.org.uk>
Cc: <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Lee Jones <lee@kernel.org>
Subject: [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer
Date: Fri, 27 Mar 2015 13:35:53 +0200	[thread overview]
Message-ID: <1427456155-28990-4-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1427456155-28990-1-git-send-email-peter.ujfalusi@ti.com>

The vd->node is removed from the lists when the transfer started so the
vchan_get_all_descriptors() will not find it. This results memory leak.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
CC: Stephen Warren <swarren@wwwdotorg.org>
CC: Lee Jones <lee@kernel.org>
---
 drivers/dma/bcm2835-dma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 0723096fb50a..c92d6a70ccf3 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -475,6 +475,7 @@ static int bcm2835_dma_terminate_all(struct dma_chan *chan)
 	 * c->desc is NULL and exit.)
 	 */
 	if (c->desc) {
+		bcm2835_dma_desc_free(&c->desc->vd);
 		c->desc = NULL;
 		bcm2835_dma_abort(c->chan_base);
 
-- 
2.3.3


  parent reply	other threads:[~2015-03-27 11:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 11:35 [PATCH 0/5] dmaengine: Fix memory leak amongs virt-dma users Peter Ujfalusi
2015-03-27 11:35 ` [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers Peter Ujfalusi
2015-03-30 17:48   ` Vinod Koul
2015-03-27 11:35 ` [PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer Peter Ujfalusi
2015-03-30 17:48   ` Vinod Koul
2015-03-27 11:35 ` Peter Ujfalusi [this message]
2015-03-28  3:57   ` [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a " Stephen Warren
2015-03-28 21:50     ` Peter Ujfalusi
2015-03-30 17:48   ` Vinod Koul
2015-03-27 11:35 ` [PATCH 4/5] dmaengine: hsu: " Peter Ujfalusi
2015-03-27 12:01   ` Andy Shevchenko
2015-03-30 17:37     ` Vinod Koul
2015-04-28 11:17       ` 'Greg Kroah-Hartman'
2015-05-04 11:04         ` Vinod Koul
2015-05-07 16:26   ` Andy Shevchenko
2015-03-27 11:35 ` [PATCH 5/5] dmaengine: moxart-dma: " Peter Ujfalusi
2015-03-30 17:49   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427456155-28990-4-git-send-email-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=swarren@wwwdotorg.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).