From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: fengguang.wu@intel.com, varun@chelsio.com, kbuild-all@01.org,
hariprasad@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Ariel Elior" <ariel.elior@qlogic.com>,
"Jeff Kirsher" <jeffrey.t.kirsher@intel.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Bruce Allan" <bruce.w.allan@intel.com>,
"Carolyn Wyborny" <carolyn.wyborny@intel.com>,
"Don Skidmore" <donald.c.skidmore@intel.com>,
"Greg Rose" <gregory.v.rose@intel.com>,
"Matthew Vick" <matthew.vick@intel.com>,
"John Ronciak" <john.ronciak@intel.com>,
"Mitch Williams" <mitch.a.williams@intel.com>,
"Linux NICS" <linux.nics@intel.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
e1000-devel@lists.sourceforge.net,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0
Date: Sun, 29 Mar 2015 18:25:12 -0700 [thread overview]
Message-ID: <1427678712.2715.52.camel@perches.com> (raw)
In-Reply-To: <20150329.121655.2092434262655191613.davem@davemloft.net>
Use bool constants as the return values instead of 1 and 0.
Signed-off-by: Joe Perches <joe@perches.com>
---
> To be honest I'd might rather get bunches of these, there has to be a ton
> of them, than a slow trickle of one every few weeks/days.
There aren't too many...
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++--
drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 039b0c1..9980912 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -11610,7 +11610,7 @@ static bool bnx2x_get_dropless_info(struct bnx2x *bp)
u32 cfg;
if (IS_VF(bp))
- return 0;
+ return false;
if (IS_MF(bp) && !CHIP_IS_E1x(bp)) {
/* Take function: tmp = func */
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
index 02ffb30..ccaecb1 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
@@ -1351,7 +1351,7 @@ static bool reg_pattern_test(struct ixgbe_adapter *adapter, u64 *data, int reg,
if (ixgbe_removed(adapter->hw.hw_addr)) {
*data = 1;
- return 1;
+ return true;
}
for (pat = 0; pat < ARRAY_SIZE(test_pattern); pat++) {
before = ixgbe_read_reg(&adapter->hw, reg);
@@ -1376,7 +1376,7 @@ static bool reg_set_and_check(struct ixgbe_adapter *adapter, u64 *data, int reg,
if (ixgbe_removed(adapter->hw.hw_addr)) {
*data = 1;
- return 1;
+ return true;
}
before = ixgbe_read_reg(&adapter->hw, reg);
ixgbe_write_reg(&adapter->hw, reg, write & mask);
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index 2111b91..6008eee 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1062,7 +1062,7 @@ static bool get_bool(struct platform_device *ofdev, const char *s)
} else {
dev_warn(&ofdev->dev, "Parameter %s not found,"
"defaulting to false\n", s);
- return 0;
+ return false;
}
}
next prev parent reply other threads:[~2015-03-30 1:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201503260524.AdqSbov9%fengguang.wu@intel.com>
2015-03-25 21:55 ` [PATCH] cxgb4: fix boolreturn.cocci warnings kbuild test robot
2015-03-25 22:14 ` Joe Perches
2015-03-29 19:16 ` David Miller
2015-03-30 1:25 ` Joe Perches [this message]
2015-03-30 1:29 ` [PATCH net-next] wireless: Use bool function returns of true/false instead of 1/0 Joe Perches
2015-03-30 1:46 ` Larry Finger
2015-03-30 1:49 ` Joe Perches
2015-04-07 17:11 ` [net-next] wireless: Use bool function returns of true/false insteadof 1/0 Kalle Valo
2015-03-30 20:28 ` [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0 Jeff Kirsher
2015-03-31 11:10 ` Michal Simek
2015-03-31 19:49 ` Joe Perches
2015-03-31 18:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427678712.2715.52.camel@perches.com \
--to=joe@perches.com \
--cc=ariel.elior@qlogic.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=fengguang.wu@intel.com \
--cc=gregory.v.rose@intel.com \
--cc=hariprasad@chelsio.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.nics@intel.com \
--cc=matthew.vick@intel.com \
--cc=michal.simek@xilinx.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).