From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752620AbbCaIgj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 Mar 2015 04:36:39 -0400
Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:37452 "EHLO
	lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751121AbbCaIgh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 Mar 2015 04:36:37 -0400
Message-ID: <1427790991.2408.51.camel@x220>
Subject: Re: [PATCH char-misc-next v4 03/13] misc: mic: SCIF Hardware Bus
From: Paul Bolle <pebolle@tiscali.nl>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        Dave Jiang <dave.jiang@intel.com>, Nikhil Rao <nikhil.rao@intel.com>,
        Ashutosh Dixit <ashutosh.dixit@intel.com>
Date: Tue, 31 Mar 2015 10:36:31 +0200
In-Reply-To: <c53ee4eb6001327c9330837ca246ab9fe0fa12b6.1427763968.git.sudeep.dutt@intel.com>
References: <cover.1427763968.git.sudeep.dutt@intel.com>
	 <c53ee4eb6001327c9330837ca246ab9fe0fa12b6.1427763968.git.sudeep.dutt@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2015-03-30 at 18:36 -0700, Sudeep Dutt wrote:
> --- a/drivers/misc/mic/Kconfig
> +++ b/drivers/misc/mic/Kconfig

> +config SCIF_BUS
> +	tristate "SCIF Bus Driver"
> +	depends on 64BIT && PCI && X86 && X86_DEV_DMA_OPS

Can't this be simplified to just
	depends on X86_64 && PCI

or is this bus expected to be used outside of 64 bit X86?

> +	help
> +	  This option is selected by any driver which registers a
> +	  device or driver on the SCIF Bus, such as CONFIG_INTEL_MIC_HOST
> +	  and CONFIG_INTEL_MIC_CARD.
> +
> +	  If you are building a host/card kernel with an Intel MIC device
> +	  then say M (recommended) or Y, else say N. If unsure say N.
> +
> +	  More information about the Intel MIC family as well as the Linux
> +	  OS and tools for MIC to use with this driver are available from
> +	  <http://software.intel.com/en-us/mic-developer>.


Paul Bolle