From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752400AbbCaJJs (ORCPT ); Tue, 31 Mar 2015 05:09:48 -0400 Received: from smtprelay0019.hostedemail.com ([216.40.44.19]:51495 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751095AbbCaJJn (ORCPT ); Tue, 31 Mar 2015 05:09:43 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2895:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3873:4321:5007:6119:6261:7903:10004:10400:10848:11026:11232:11658:11914:12438:12517:12519:12555:12663:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: roll14_8ed1577e1224e X-Filterd-Recvd-Size: 1554 Message-ID: <1427792978.10376.5.camel@perches.com> Subject: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0 From: Joe Perches To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Ingo Molnar Date: Tue, 31 Mar 2015 02:09:38 -0700 In-Reply-To: <20150331085320.GR27490@worktop.programming.kicks-ass.net> References: <93bd3fb8db14c75508f7169840824539a3f89606.1427759010.git.joe@perches.com> <20150331085320.GR27490@worktop.programming.kicks-ass.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-31 at 10:53 +0200, Peter Zijlstra wrote: > On Mon, Mar 30, 2015 at 04:46:17PM -0700, Joe Perches wrote: > > Use the normal return values for bool fsnctions > > > > Update the other sets of ret in try_wait_for_completion. > > I'm missing a why; why are you doing this? It's just a trivial little consistency patch to make bool functions return bool values instead of 1 or 0 (even though of course 1 and 0 are the values for true and false) There's something like 13000 uses of return true or return false in the tree vs these 180 or so uses of 1 and 0.