From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754563AbbCaRhW (ORCPT ); Tue, 31 Mar 2015 13:37:22 -0400 Received: from smtprelay0078.hostedemail.com ([216.40.44.78]:49438 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752107AbbCaRhR (ORCPT ); Tue, 31 Mar 2015 13:37:17 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2895:3138:3139:3140:3141:3142:3350:3622:3865:3867:3871:3872:3874:4250:4321:5007:6261:8660:10004:10400:10848:11232:11658:11914:12296:12517:12519:12740:13069:13148:13230:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bread10_3f5b7b827475c X-Filterd-Recvd-Size: 1528 Message-ID: <1427823434.10376.33.camel@perches.com> Subject: Re: [PATCH 1/7] lib/vsprintf: add %*pg format specifier From: Joe Perches To: Dmitry Monakhov Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, axboe@kernel.dk, viro@zeniv.linux.org.uk, dm-devel@redhat.com Date: Tue, 31 Mar 2015 10:37:14 -0700 In-Reply-To: <1427821576.10376.29.camel@perches.com> References: <1427817681-4494-1-git-send-email-dmonakhov@openvz.org> <1427817681-4494-2-git-send-email-dmonakhov@openvz.org> <1427821576.10376.29.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-31 at 10:06 -0700, Joe Perches wrote: > On Tue, 2015-03-31 at 20:01 +0400, Dmitry Monakhov wrote: > > This allow to directly print block_device name. > > Currently one should use bdevname() with temporal char buf[BDEVNAME_SIZE]. > > This is very ineffective because bloat stack usage for deep IO call-traces Perhaps it would be useful to update the disk_name/bdevname functions to take a buffer length along with the char * so that buffer overflows could not occur. That would also allow this function to use bdevname directly.