From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753388AbbCaRzN (ORCPT ); Tue, 31 Mar 2015 13:55:13 -0400 Received: from mail-bn1bon0114.outbound.protection.outlook.com ([157.56.111.114]:5920 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751243AbbCaRzJ (ORCPT ); Tue, 31 Mar 2015 13:55:09 -0400 Message-ID: <1427824493.22867.226.camel@freescale.com> Subject: Re: [PATCH] powerpc/83xx: add support for mpc8306 From: Scott Wood To: Filip Brozovic CC: , , , Date: Tue, 31 Mar 2015 12:54:53 -0500 In-Reply-To: <1427561968-32049-1-git-send-email-fbrozovic@gmail.com> References: <1427561968-32049-1-git-send-email-fbrozovic@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:2:5800:3f7:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BY1PR0201CA0003.namprd02.prod.outlook.com (25.160.191.141) To BY1PR03MB1482.namprd03.prod.outlook.com (25.162.210.140) Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1404; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377424004)(87976001)(47776003)(50986999)(23676002)(42186005)(86362001)(76176999)(62966003)(2950100001)(77156002)(36756003)(122386002)(103116003)(40100003)(46102003)(575784001)(5820100001)(50226001)(33646002)(92566002)(50466002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1482;H:[IPv6:2601:2:5800:3f7:12bf:48ff:fe84:c9a0];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:BY1PR03MB1482;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Forefront-PRVS: 0532BF6DC2 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2015 17:55:03.7335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-03-28 at 17:59 +0100, Filip Brozovic wrote: > diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c > index c2518cd..f967ff6 100644 > --- a/arch/powerpc/sysdev/qe_lib/qe.c > +++ b/arch/powerpc/sysdev/qe_lib/qe.c > @@ -278,12 +278,17 @@ static void qe_snums_init(void) > 0xF4, 0xF5, 0xFC, 0xFD, > }; > static const u8 snum_init_46[] = { > +#if !defined(CONFIG_QE_8306) > 0x04, 0x05, 0x0C, 0x0D, 0x14, 0x15, 0x1C, 0x1D, > - 0x24, 0x25, 0x2C, 0x2D, 0x34, 0x35, 0x88, 0x89, > - 0x98, 0x99, 0xA8, 0xA9, 0xB8, 0xB9, 0xC8, 0xC9, > - 0xD8, 0xD9, 0xE8, 0xE9, 0x08, 0x09, 0x18, 0x19, > - 0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59, > - 0x68, 0x69, 0x78, 0x79, 0x80, 0x81, > + 0x24, 0x25, 0x2C, 0x2D, 0x34, 0x35, > +#endif > + 0x88, 0x89, 0x98, 0x99, 0xA8, 0xA9, 0xB8, 0xB9, > + 0xC8, 0xC9, 0xD8, 0xD9, 0xE8, 0xE9, > +#if !defined(CONFIG_QE_8306) > + 0x08, 0x09, 0x18, 0x19, 0x28, 0x29, 0x38, 0x39, > + 0x48, 0x49, 0x58, 0x59, 0x68, 0x69, 0x78, 0x79, > + 0x80, 0x81, > +#endif > }; > static const u8 *snum_init; This breaks multiplatform support. You need to determine this at runtime. -Scott