From: Chris Mason <clm@fb.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Josef Bacik <jbacik@fb.com>, David Sterba <dsterba@suse.cz>,
<linux-btrfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] fs: btrfs: Add missing include file
Date: Wed, 1 Apr 2015 16:03:18 -0400 [thread overview]
Message-ID: <1427918598.20109.1@mail.thefacebook.com> (raw)
In-Reply-To: <551C4DCC.2090208@roeck-us.net>
On Wed, Apr 1, 2015 at 3:58 PM, Guenter Roeck <linux@roeck-us.net>
wrote:
> On 04/01/2015 12:28 PM, Chris Mason wrote:
>> On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck <linux@roeck-us.net>
>> wrote:
>>> On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote:
>>>> Building alpha:allmodconfig fails with
>>>>
>>>> fs/btrfs/inode.c: In function 'check_direct_Excellent idea.
>>>> Done,IO':
>>>> fs/btrfs/inode.c:8050:2: error: implicit declaration of function
>>>> 'iov_iter_alignment'
>>>>
>>>> due to a missing include file.
>>>>
>>>> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h")
>>>> Cc: Christoph Hellwig <hch@lst.de>
>>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>>> ---
>>>
>>> This problem still affects the following builds as of today.
>>>
>>> alpha:allmodconfig
>>> i386:allyesconfig
>>> i386:allmodconfig
>>> m68k:allmodconfig
>>> mips:allmodconfig
>>> xtensa:allmodconfig
>>>
>>> and thus probabably many other allmodconfig builds which I don't
>>> try to build.
>>>
>>> This is getting really annoying, and prevents us from finding and
>>> fixing
>>> other build problems.
>>>
>>> It has been more than two weeks since I submitted the patch. This
>>> suggests
>>> that the patch got lost otr that the Powers That Be don't care.
>>> Which one
>>> is it ?
>>>
>>> Should I request to revert 3737c63e1fb0 instead ?
>>
>> I'll put the include into my branch for -next, thanks!
>>
>
> I have not seen the problem in the latest -next build,
> which presumably means that some other patch must have
> fixed the problem or at least hides it now. No idea
> which one, though.
It's not immediately obvious what might have fixed it, so I'll keep
this patch in my -next for today at least ;)
-chris
prev parent reply other threads:[~2015-04-01 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 8:58 [PATCH] fs: btrfs: Add missing include file Guenter Roeck
2015-03-13 9:01 ` Guenter Roeck
2015-03-13 9:14 ` David Sterba
2015-03-30 3:24 ` Guenter Roeck
2015-04-01 19:28 ` Chris Mason
2015-04-01 19:58 ` Guenter Roeck
2015-04-01 20:03 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427918598.20109.1@mail.thefacebook.com \
--to=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=hch@lst.de \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).