From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710AbbDBLBN (ORCPT ); Thu, 2 Apr 2015 07:01:13 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:47812 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbbDBLBJ (ORCPT ); Thu, 2 Apr 2015 07:01:09 -0400 X-AuditID: cbfec7f4-b7f126d000001e9a-9f-551d20c62a4a From: Krzysztof Kozlowski To: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Alexandre Belloni Cc: Marek Szyprowski , Krzysztof Kozlowski Subject: [PATCH] rtc: rtc-s3c: Fix failed first read of RTC time Date: Thu, 02 Apr 2015 13:00:59 +0200 Message-id: <1427972459-6480-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHJMWRmVeSWpSXmKPExsVy+t/xy7rHFGRDDb7eMrVYcvEqu0XHtcVM Fq9fGFpc3jWHzWLG+X1MFmuP3GW32N/ZwejA7vFk00VGjz0TT7J59G1Zxegxfd5PJo/Pm+QC WKO4bFJSczLLUov07RK4MqZeXs1a0MhXcXD6LfYGxnXcXYycHBICJhKfjp5mgbDFJC7cW8/W xcjFISSwlFHi9ZZ5jBBOH5PEl6UtzCBVbALGEpuXLwGrEhE4xihx4v0OJpAEs0CCxN35Z9hA bGEBB4njM5vB4iwCqhIXJy4Ei/MKuEnM6TjMBLFOTuLkscmsExi5FzAyrGIUTS1NLihOSs81 1CtOzC0uzUvXS87P3cQICZMvOxgXH7M6xCjAwajEw3vjk3SoEGtiWXFl7iFGCQ5mJRHeP+Ky oUK8KYmVValF+fFFpTmpxYcYmTg4pRoY2Vcs61geKbFsrsXCA6ej+t8e4yldIHPTcp7vajnT hZnPHy788EVj71OnWqnbu25xznTuPZJ9a13nrS3TYpdw/vbZWdR0LF1K1qR3YVC0rG586enD hdveicS7B8Rp+P4ykyh1W39cuqH0jq/Xo/C08k+LYmxDY++4/Wmt3l4mXFXgsK3xz+UsJZbi jERDLeai4kQA9ZXLyvEBAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Initialize the device time (if it is wrong) before registering RTC device to fix following error message during rtc-s3c probe: [ 2.215414] rtc (null): read_time: fail to read [ 2.216322] s3c-rtc 10070000.rtc: rtc core: registered s3c as rtc1 Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s3c.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index 5e162eaad277..1d3a4c58fec4 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -496,6 +496,22 @@ static int s3c_rtc_probe(struct platform_device *pdev) device_init_wakeup(&pdev->dev, 1); + /* Check RTC Time */ + s3c_rtc_gettime(&pdev->dev, &rtc_tm); + + if (rtc_valid_tm(&rtc_tm)) { + rtc_tm.tm_year = 100; + rtc_tm.tm_mon = 0; + rtc_tm.tm_mday = 1; + rtc_tm.tm_hour = 0; + rtc_tm.tm_min = 0; + rtc_tm.tm_sec = 0; + + s3c_rtc_settime(&pdev->dev, &rtc_tm); + + dev_warn(&pdev->dev, "warning: invalid RTC value so initializing it\n"); + } + /* register RTC and exit */ info->rtc = devm_rtc_device_register(&pdev->dev, "s3c", &s3c_rtcops, THIS_MODULE); @@ -519,22 +535,6 @@ static int s3c_rtc_probe(struct platform_device *pdev) goto err_nortc; } - /* Check RTC Time */ - s3c_rtc_gettime(&pdev->dev, &rtc_tm); - - if (rtc_valid_tm(&rtc_tm)) { - rtc_tm.tm_year = 100; - rtc_tm.tm_mon = 0; - rtc_tm.tm_mday = 1; - rtc_tm.tm_hour = 0; - rtc_tm.tm_min = 0; - rtc_tm.tm_sec = 0; - - s3c_rtc_settime(&pdev->dev, &rtc_tm); - - dev_warn(&pdev->dev, "warning: invalid RTC value so initializing it\n"); - } - if (info->data->select_tick_clk) info->data->select_tick_clk(info); -- 1.9.1