From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754017AbbDBOkF (ORCPT ); Thu, 2 Apr 2015 10:40:05 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:60068 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514AbbDBOgf (ORCPT ); Thu, 2 Apr 2015 10:36:35 -0400 X-AuditID: cbfec7f5-b7fc86d0000066b7-00-551d5343a27a From: Krzysztof Kozlowski To: Sangbeom Kim , Samuel Ortiz , Lee Jones , linux-kernel@vger.kernel.org, Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Javier Martinez Canillas , Krzysztof Kozlowski Subject: [PATCH 2/2] ARM: dts: Fix pinctrl settings for S2MPS11 RTC alarm IRQ on Arndale Octa Date: Thu, 02 Apr 2015 16:36:16 +0200 Message-id: <1427985376-20420-3-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1427985376-20420-1-git-send-email-k.kozlowski@samsung.com> References: <1427985376-20420-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnluLIzCtJLcpLzFFi42I5/e/4FV3nYNlQg0mHpS3mHznHanH0d4HF 6xeGFv2PXzNb3P96lNFi0+NrrBaXd81hs5hxfh+TxeluVouLK74wOXB5/H1+ncVj06pONo87 1/awecw7GeixeUm9R9+WVYwenzfJBbBHcdmkpOZklqUW6dslcGV8eraTteAYV8WcxQtYGhiv cXQxcnJICJhIbFj4lRXCFpO4cG89WxcjF4eQwFJGidf3VrJDOH1MEos3dbOAVLEJGEtsXr4E rEpEYBqTxN+TO4AcDg5mgXyJ2595QWqEBeIlju+/zw4SZhFQlVj2LRvE5BVwl7i9tRRil5zE yWOTwfZyCnhINH9oZgIpEQIqWbo/bQIj7wJGhlWMoqmlyQXFSem5RnrFibnFpXnpesn5uZsY IYH3dQfj0mNWhxgFOBiVeHgbrGVChVgTy4orcw8xSnAwK4nwPtCWDRXiTUmsrEotyo8vKs1J LT7EyMTBKdXAyDKBXTlG2lHrSn3X4ecPCjuEFT2+r08ti3uQHffHOvLLP3lZr7Q+i5uzlrd0 WO1+cjTjecSHSVPC3m/7WCAVtWu3mey5V5MMg2cxNi9/l5F+eO39qHsh+2Y3PNS8reTQbFtU 7//kraaog4F1x7a6ndHcpXeEp0/4cDR9q2m71pctrzKfmu18ocRSnJFoqMVcVJwIAAxkeSEa AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Arndale Octa the S2MPS11 RTC alarm interrupt was not handled at all because of wrong configuration of interrupt and gpx3-2. 1. Interrupt is signaled by falling edge. 2. This GPIO line is hard-wired on the board to PVDD_APIO_1V8 through a resistor so pull-up/down must be disabled. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts index d78fcd997ce6..97346df31d41 100644 --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts @@ -87,7 +87,9 @@ s2mps11,buck4-ramp-enable = <1>; interrupt-parent = <&gpx3>; - interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; + pinctrl-names = "default"; + pinctrl-0 = <&s2mps11_irq>; s2mps11_osc: clocks { #clock-cells = <1>; @@ -379,3 +381,12 @@ clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; clock-names = "rtc", "rtc_src"; }; + +&pinctrl_0 { + s2mps11_irq: s2mps11-irq { + samsung,pins = "gpx3-2"; + samsung,pin-function = <0xf>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; +}; -- 1.9.1