From: Scott Wood <scottwood@freescale.com>
To: Zhao Chenhui-B35336 <chenhui.zhao@freescale.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jin Zhengxiong-R64188" <Jason.Jin@freescale.com>
Subject: Re: [2/4] powerpc/rcpm: add RCPM driver
Date: Thu, 2 Apr 2015 10:50:50 -0500 [thread overview]
Message-ID: <1427989850.22867.266.camel@freescale.com> (raw)
In-Reply-To: <1427970805609.21194@freescale.com>
On Thu, 2015-04-02 at 05:33 -0500, Zhao Chenhui-B35336 wrote:
> > +static int rcpm_v2_plat_enter_state(int state)
> > +{
> > + u32 *pmcsr_reg = &rcpm_v2_regs->powmgtcsr;
> > + int ret = 0;
> > + int result;
> > +
> > + switch (state) {
> > + case PLAT_PM_LPM20:
> > + /* clear previous LPM20 status */
> > + setbits32(pmcsr_reg, RCPM_POWMGTCSR_P_LPM20_ST);
>
> How would the bit be set when you enter here, given that you wait for it
> to clear when leaving?
>
> [chenhui] Actually, the bit is not used by software. Just follow the instruction in RM.
Sorry, I missed the "_P_" and thought it was RCPM_POWMGTCSR_LPM20_ST.
-Scott
next prev parent reply other threads:[~2015-04-02 15:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 10:18 [PATCH 1/4] powerpc/cache: add cache flush operation for various e500 Chenhui Zhao
2015-03-26 10:18 ` [PATCH 2/4] powerpc/rcpm: add RCPM driver Chenhui Zhao
2015-03-31 1:30 ` [2/4] " Scott Wood
2015-04-02 10:33 ` chenhui.zhao
2015-04-02 15:50 ` Scott Wood [this message]
2015-03-26 10:18 ` [PATCH 3/4] powerpc: support CPU hotplug for e500mc, e5500 and e6500 Chenhui Zhao
2015-03-31 2:07 ` [3/4] " Scott Wood
2015-04-02 11:16 ` chenhui.zhao
2015-04-02 16:03 ` Scott Wood
2015-04-03 2:54 ` chenhui.zhao
2015-03-26 10:18 ` [PATCH 4/4] powerpc/85xx: support sleep feature on QorIQ SoCs with RCPM Chenhui Zhao
2015-03-31 2:35 ` [4/4] " Scott Wood
2015-04-02 11:18 ` chenhui.zhao
2015-03-31 1:10 ` [1/4] powerpc/cache: add cache flush operation for various e500 Scott Wood
2015-04-02 10:14 ` chenhui.zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427989850.22867.266.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Jason.Jin@freescale.com \
--cc=chenhui.zhao@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).