From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752261AbbDDCEH (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Apr 2015 22:04:07 -0400
Received: from mail-wi0-f169.google.com ([209.85.212.169]:36867 "EHLO
	mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751491AbbDDCED (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Apr 2015 22:04:03 -0400
Message-ID: <1428113039.3189.6.camel@gmail.com>
Subject: Re: [PATCH 2/2] nohz: make nohz_full imply isolcpus
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Chris Metcalf <cmetcalf@ezchip.com>
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Date: Sat, 04 Apr 2015 04:03:59 +0200
In-Reply-To: <551EE81C.3050605@ezchip.com>
References: <1428078248-5425-1-git-send-email-cmetcalf@ezchip.com>
	 <1428078248-5425-2-git-send-email-cmetcalf@ezchip.com>
	 <1428084499.3475.40.camel@gmail.com> <551EE81C.3050605@ezchip.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.0 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2015-04-03 at 15:21 -0400, Chris Metcalf wrote:
> On 04/03/2015 02:08 PM, Mike Galbraith wrote:
> > On Fri, 2015-04-03 at 12:24 -0400,  cmetcalf@ezchip.comwrote:
> > > From: Chris Metcalf <cmetcalf@ezchip.com>
> > > 
> > > It's not clear that nohz_full is useful without isolcpus also
> > > set, since otherwise the scheduler has to run periodically to
> > > try to determine whether to steal work from other cores.
> > > 
> > > Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com>
> > Ack!  nohz_full= as currently defined makes zero sense when the cpu
> > set (which should be spelled cpuset) remains connected to the
> > scheduler.  Perturbation of tasks to PREVENT cpu domination is what
> > the scheduler does for a living.  Sprinkling microsecond savers all
> > over the kernel is pretty silly if you don't shut down the mother 
> > lode
> > of perturbation.
> 
> Sounds like a thumbs up for this patch, then?  :-)

Yup.  The other thumb turns in the up direction when folks start 
spelling cpuset properly ;-)  Static isolcpus was supposed to go away.

        -Mike