From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753204AbbDGDjo (ORCPT ); Mon, 6 Apr 2015 23:39:44 -0400 Received: from ozlabs.org ([103.22.144.67]:53930 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753047AbbDGDjn (ORCPT ); Mon, 6 Apr 2015 23:39:43 -0400 Message-ID: <1428377982.25172.5.camel@ellerman.id.au> Subject: Re: [PATCH v4] x86, selftests: Add sigreturn selftest From: Michael Ellerman To: Andy Lutomirski Cc: Ingo Molnar , x86@kernel.org, Shuah Khan , Borislav Petkov , Denys Vlasenko , Steven Rostedt , linux-kernel@vger.kernel.org Date: Tue, 07 Apr 2015 13:39:42 +1000 In-Reply-To: <8de66ae0f9906a65609ce5481675fc53e1d58eb7.1428371988.git.luto@kernel.org> References: <8de66ae0f9906a65609ce5481675fc53e1d58eb7.1428371988.git.luto@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-04-06 at 19:01 -0700, Andy Lutomirski wrote: > This is my sigreturn test, added mostly unchanged from its old home. > It exercises the sigreturn(2) syscall, specifically focusing on its > interactions with various IRET corner cases. It tests for correct > behavior in several areas that were historically dangerously buggy. > For example, it exercises espfix on kernels of both bitnesses under > various conditions, and it contains exploits for several now-fixed > bugs in IRET error handling. > > If you run it on older kernels, your system will crash. It probably > won't eat your data in the process. > > There is no released kernel on which the sigreturn_64 test will > pass, but it passes on tip:x86/asm. > > IMO it's unfortunate that I need to provide a special script to run > tests. I'd rather just list my targets. If you use lib.mk you can. https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next See for example: https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=next&id=5744de542dd4b963c2975e6f70844ce2899864e4 cheers