From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jean Delvare <jdelvare@suse.de>, Wolfram Sang <wsa@the-dreams.de>,
Rodolfo Giometti <giometti@enneenne.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Mark Brown <broonie@kernel.org>, Willy Tarreau <willy@meta-x.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-spi@vger.kernel.org, devel@driverdev.osuosl.org,
alsa-devel@alsa-project.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 06/14] spi: butterfly: return proper error values from attach
Date: Wed, 8 Apr 2015 16:50:32 +0530 [thread overview]
Message-ID: <1428492040-5581-7-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1428492040-5581-1-git-send-email-sudipm.mukherjee@gmail.com>
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/spi/spi-butterfly.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-butterfly.c b/drivers/spi/spi-butterfly.c
index 9a95862..7df16c8 100644
--- a/drivers/spi/spi-butterfly.c
+++ b/drivers/spi/spi-butterfly.c
@@ -190,7 +190,7 @@ static struct flash_platform_data flash = {
/* REVISIT remove this ugly global and its "only one" limitation */
static struct butterfly *butterfly;
-static void butterfly_attach(struct parport *p)
+static int butterfly_attach(struct parport *p)
{
struct pardevice *pd;
int status;
@@ -199,7 +199,7 @@ static void butterfly_attach(struct parport *p)
struct device *dev = p->physport->dev;
if (butterfly || !dev)
- return;
+ return -ENODEV;
/* REVISIT: this just _assumes_ a butterfly is there ... no probe,
* and no way to be selective about what it binds to.
@@ -287,7 +287,7 @@ static void butterfly_attach(struct parport *p)
pr_info("%s: AVR Butterfly\n", p->name);
butterfly = pp;
- return;
+ return 0;
clean2:
/* turn off VCC */
@@ -300,6 +300,7 @@ clean0:
(void) spi_master_put(pp->bitbang.master);
done:
pr_debug("%s: butterfly probe, fail %d\n", p->name, status);
+ return status;
}
static void butterfly_detach(struct parport *p)
--
1.8.1.2
next prev parent reply other threads:[~2015-04-08 11:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 11:20 [PATCH 00/14] parport: check success of attach call Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 01/14] parport: return value of attach and parport_register_driver Sudip Mukherjee
2015-04-08 11:38 ` Dan Carpenter
2015-04-08 11:44 ` Dan Carpenter
2015-04-08 12:14 ` Sudip Mukherjee
2015-04-08 11:50 ` Sudip Mukherjee
2015-04-08 12:27 ` Dan Carpenter
2015-04-08 17:56 ` Willy Tarreau
2015-04-08 11:20 ` [PATCH 02/14] ALSA: portman2x4: return proper error values from attach Sudip Mukherjee
2015-04-08 13:32 ` Sergei Shtylyov
2015-04-08 13:40 ` Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 03/14] ALSA: mts64: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 04/14] staging: panel: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 05/14] spi: lm70llp: " Sudip Mukherjee
2015-04-08 11:20 ` Sudip Mukherjee [this message]
2015-04-08 11:20 ` [PATCH 07/14] [SCSI] ppa: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 08/14] [SCSI] imm: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 09/14] pps: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 10/14] " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 11/14] net: plip: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 12/14] i2c-parport: " Sudip Mukherjee
2015-04-09 7:13 ` Wolfram Sang
2015-04-09 9:33 ` Jean Delvare
2015-04-09 10:25 ` Wolfram Sang
2015-04-10 5:05 ` Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 13/14] ppdev: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 14/14] char: lp: " Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428492040-5581-7-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=JBottomley@parallels.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=willy@meta-x.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).