From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756894AbbDPHN7 (ORCPT ); Thu, 16 Apr 2015 03:13:59 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:53511 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbbDPHNu (ORCPT ); Thu, 16 Apr 2015 03:13:50 -0400 Message-ID: <1429168424.26621.1.camel@mm-sol.com> Subject: Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection From: "Ivan T. Ivanov" To: Chanwoo Choi Cc: Peter Chen , "Balbi, Felipe" , "ABRAHAM, KISHON VIJAY" , Roger Quadros , Robert Baldyga , myungjoo.ham@samsung.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com Date: Thu, 16 Apr 2015 10:13:44 +0300 In-Reply-To: <552F5E17.5020902@samsung.com> References: <55278DD3.3020409@samsung.com> <55279550.1060609@samsung.com> <552CE579.6060702@ti.com> <552CE5C0.3010207@ti.com> <552CEC97.1050205@samsung.com> <552CEE42.1050907@ti.com> <552CFA1E.5070400@samsung.com> <20150415032734.GA29095@shlinux2> <552E1862.6090709@ti.com> <552E2EBF.5090906@samsung.com> <20150416015922.GB22269@shlinux2> <552F5E17.5020902@samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1.2~trusty Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote: > Hi Peter, > > On 04/16/2015 10:59 AM, Peter Chen wrote: > > > > Ok, from USB point, external id/vbus value can't decide > > which role the controller will be, the controller driver > > will decide role according to many things, eg, user configurations, > > id/vbus value, OTG HNP, etc. > > > > So, from USB controller/phy driver, it doesn't care which cable is > > inserted, it cares about id/vbus value. Eg, it can get id/vbus value > > and it will be notified when the id/vbus value has changed. > > OK, I change the notifier name and add notifier events as following: > > - extcon_{register|unregister}_usb_notifier(struct extcon_dev *edev, struct notifier_block *nb); > - list of notifier events > #define EXTCON_USB_ID_L_VBUS_L0 /* ID low and VBUS low */ > #define EXTCON_USB_ID_L_VBUS_H1 /* ID low and VBUS high */ > #define EXTCON_USB_ID_H_VBUS_L2 /* ID high and VBUS low */ > #define EXTCON_USB_ID_H_VBUS_H3 /* ID high and VBUS high */ I am still confused, why we mix ID and VBUS events into one? Those are two lines and they are not necessarily handled by the same extcon_dev. Ivan