From: Faiz Abbas <faiz_abbas@ti.com>
To: Tero Kristo <t-kristo@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <will@kernel.org>, <catalin.marinas@arm.com>, <nm@ti.com>
Subject: Re: [PATCH 0/2] Enable GPIO and I2C configs for TI's J721e platform
Date: Thu, 8 Oct 2020 15:10:57 +0530 [thread overview]
Message-ID: <142b9d12-ea65-320f-aef9-583389aabb3e@ti.com> (raw)
In-Reply-To: <51978593-fe09-3740-ef90-deac8ef3d2f2@ti.com>
Tero,
On 08/10/20 2:49 pm, Tero Kristo wrote:
> On 08/10/2020 11:59, Faiz Abbas wrote:
>> Tero,
>>
>> On 06/10/20 6:40 pm, Tero Kristo wrote:
>>> On 06/10/2020 16:03, Faiz Abbas wrote:
>>>> Hi Tero,
>>>>
>>>> On 06/10/20 5:21 pm, Tero Kristo wrote:
>>>>> On 02/10/2020 19:45, Faiz Abbas wrote:
>>>>>> The following patches enable configs in the arm64 defconfig to support
>>>>>> GPIO and I2C support on TI's J721e platform.
>>>>>>
>>>>>> Faiz Abbas (2):
>>>>>> arm64: defconfig: Enable OMAP I2C driver
>>>>>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>>>>>
>>>>>> arch/arm64/configs/defconfig | 2 ++
>>>>>> 1 file changed, 2 insertions(+)
>>>>>>
>>>>>
>>>>> Why are you enabling these?
>>>>>
>>>>> Are they required for booting the board?
>>>>>
>>>>> If not, they shall not be enabled, as it just clutters the arm64 defconfig unnecessarily.
>>>>>
>>>>
>>>> They are required because the SD card regulators need gpio over i2c expander and also
>>>> soc gpio support to come up in UHS modes.
>>>
>>> Is that needed for boot support? If it is only needed with UHS cards, that does not seem important enough for me. We can already boot the board via other means.
>>
>> Without these configs, the regulator drivers keep EPROBE_DEFERing waiting for their gpio drivers
>> to probe and SD card never comes up. This configuration happens before any UHS capabilities are detected.
>>
>> [ 1.326654] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
>> [ 1.333651] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
>> [ 1.340693] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
>> [ 1.489088] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
>> [ 1.496067] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
>> [ 1.510392] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
>> [ 1.543210] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
>> [ 1.550186] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
>> [ 1.568134] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
>
> This happens because you have merged/enabled UHS support or? This sounds like a regression as I haven't seen this happen before.
>
Thats right. The EPROBE_DEFERs will happen if my patches enabling UHS modes here are merged. I need to repost them for v5.11-rc1:
https://lore.kernel.org/linux-arm-kernel/20201001190541.6364-1-faiz_abbas@ti.com/
Thanks,
Faiz
next prev parent reply other threads:[~2020-10-08 9:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 16:45 [PATCH 0/2] Enable GPIO and I2C configs for TI's J721e platform Faiz Abbas
2020-10-02 16:45 ` [PATCH 1/2] arm64: defconfig: Enable OMAP I2C driver Faiz Abbas
2020-10-02 16:45 ` [PATCH 2/2] arm64: defconfig: Enable DAVINCI_GPIO driver Faiz Abbas
2020-10-02 17:02 ` [PATCH 0/2] Enable GPIO and I2C configs for TI's J721e platform Nishanth Menon
2020-10-06 8:14 ` Faiz Abbas
2020-10-06 11:51 ` Tero Kristo
2020-10-06 13:03 ` Faiz Abbas
2020-10-06 13:10 ` Tero Kristo
2020-10-08 8:59 ` Faiz Abbas
2020-10-08 9:19 ` Tero Kristo
2020-10-08 9:40 ` Faiz Abbas [this message]
2020-10-08 11:06 ` Tero Kristo
2020-10-08 11:36 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=142b9d12-ea65-320f-aef9-583389aabb3e@ti.com \
--to=faiz_abbas@ti.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).