From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753057AbbEDKpC (ORCPT ); Mon, 4 May 2015 06:45:02 -0400 Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:59976 "EHLO lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752944AbbEDKoW (ORCPT ); Mon, 4 May 2015 06:44:22 -0400 Message-ID: <1430736254.23580.2.camel@tiscali.nl> Subject: Re: [PATCH v3 3/8] mfd: arizona: Add support for WM8998 and WM1814 From: Paul Bolle To: Richard Fitzgerald Cc: lee.jones@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com, cw00.choi@samsung.com, myungjoo.ham@samsung.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, ckeepax@opensource.wolfsonmicro.com Date: Mon, 04 May 2015 12:44:14 +0200 In-Reply-To: <20150504091119.GA32076@opensource.wolfsonmicro.com> References: <1430493319-23808-1-git-send-email-rf@opensource.wolfsonmicro.com> <1430493319-23808-4-git-send-email-rf@opensource.wolfsonmicro.com> <1430560731.2187.70.camel@x220> <20150504091119.GA32076@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Richard Fitzgerald schreef op ma 04-05-2015 om 10:11 [+0100]: > Yes, I've noticed that these tests are wrong and I'm working on a patch for > it. Glad to hear I wasn't misreading that Makefile. > It's another one of those cases where more lines needs patching to fix > it than the 3 lines this WM8998 patch adds, and also fixing it potentially > breaks the build because of dependencies that were accidentally working > because they never got compiled out. So I'd prefer not to half-fix it in > these WM8998 patches it's better to let the code settle and then fix it properly. I see. Unless that fix takes very long to land, I won't be bothering you about this again. Thanks, Paul Bolle