From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbbEDNjD (ORCPT ); Mon, 4 May 2015 09:39:03 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:46056 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbbEDNjB (ORCPT ); Mon, 4 May 2015 09:39:01 -0400 Message-ID: <1430746737.2013.22.camel@sipsolutions.net> Subject: Re: Why sparse does not support context tracking? From: Johannes Berg To: Alexander Riesen Cc: linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Triplett , Christopher Li Date: Mon, 04 May 2015 15:38:57 +0200 In-Reply-To: <55475272.90705@cetitec.com> References: <55475272.90705@cetitec.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-05-04 at 13:05 +0200, Alexander Riesen wrote: > Hi, > > I tried to instrument my code (a kernel driver) with __must_hold hints > and noticed that they don't really work: a definitely broken code caused > no errors from sparse. > Revert the context tracking code > So it seems that the code has problems with different contexts. Still, it seems > a bit heavy-handed to remove it completely (assuming it worked, of course). It didn't really work. It had a lot of issues that were too big for my little wireless-focused brain :) johannes