linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, bsd@redhat.com
Subject: [PATCH 00/12] KVM: x86: SMM support
Date: Fri,  8 May 2015 13:20:22 +0200	[thread overview]
Message-ID: <1431084034-8425-1-git-send-email-pbonzini@redhat.com> (raw)

Thanks to the thorough review, I'm removing the RFC tag.  The only
major remaining point of contention is the code duplication between
virt/kvm/kvm_main.c and arch/x86/kvm/smram.c.

As before, I have only tested these patches with Q35's high SMRAM
and with open SMRAM.  Still, the TODO list has gotten smaller.

I still haven't tried using #define for offsets.  The main obstacle
is doing math to compute offsets.

Reviewed-by tags for individual patches are appreciated (especially
patches 1 and 2 which I'd like to push separately).

Paolo

RFC->v1:
- two patches (Radim's kvm_write_guest_page optimization + my fix
  for CR4.SMEP=1/CR0.WP=0) have already graduated to kvm/next
- one new patch ("kvm: x86: introduce num_emulated_msrs")
- fix pasto in do_get_msr
- introduced kvm_set_hflags
- replaced printk with tracepoints
- added smi.pending and smi.rsm_unmasks_nmi fields to kvm_vcpu_events,
  to fix NMIs and add support for latching an SMI
- SMBASE is not guest-readable
- rebased on top of kvm/next so that SMBASE is not reset on INIT
- fix access rights (shift left by 8) in 32-bit SMM state save format
- disable if !unrestricted_guest && !emulate_invalid_guest_state

TODO:
- test on AMD
- test with true SMRAM support in QEMU (only affects patch 10)

Paolo Bonzini (12):
  KVM: export __gfn_to_pfn_memslot, drop gfn_to_pfn_async
  KVM: x86: introduce num_emulated_msrs
  KVM: remove unnecessary arg from mark_page_dirty_in_slot, export it
  KVM: x86: pass host_initiated to functions that read MSRs
  KVM: x86: pass the whole hflags field to emulator and back
  KVM: x86: API changes for SMM support
  KVM: x86: stubs for SMM support
  KVM: x86: save/load state on SMM switch
  KVM: x86: add vcpu-specific functions to read/write/translate GFNs
  KVM: x86: add SMM to the MMU role
  KVM: x86: add KVM_MEM_X86_SMRAM memory slot flag
  KVM: x86: advertise KVM_CAP_X86_SMM

 Documentation/virtual/kvm/api.txt  |  58 +++-
 arch/x86/include/asm/kvm_emulate.h |   9 +-
 arch/x86/include/asm/kvm_host.h    |  42 ++-
 arch/x86/include/asm/vmx.h         |   1 +
 arch/x86/include/uapi/asm/kvm.h    |  14 +-
 arch/x86/kvm/Makefile              |   2 +-
 arch/x86/kvm/cpuid.h               |   8 +
 arch/x86/kvm/emulate.c             | 262 +++++++++++++++++-
 arch/x86/kvm/kvm_cache_regs.h      |   5 +
 arch/x86/kvm/lapic.c               |  26 +-
 arch/x86/kvm/mmu.c                 |  20 +-
 arch/x86/kvm/paging_tmpl.h         |   8 +-
 arch/x86/kvm/smram.c               | 229 ++++++++++++++++
 arch/x86/kvm/svm.c                 |  69 +++--
 arch/x86/kvm/trace.h               |  22 ++
 arch/x86/kvm/vmx.c                 |  80 +++---
 arch/x86/kvm/x86.c                 | 543 +++++++++++++++++++++++++++++++------
 include/linux/kvm_host.h           |  20 +-
 include/uapi/linux/kvm.h           |   5 +-
 virt/kvm/kvm_main.c                |  44 ++-
 20 files changed, 1223 insertions(+), 244 deletions(-)
 create mode 100644 arch/x86/kvm/smram.c

-- 
1.8.3.1


             reply	other threads:[~2015-05-08 11:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 11:20 Paolo Bonzini [this message]
2015-05-08 11:20 ` [PATCH 01/12] KVM: export __gfn_to_pfn_memslot, drop gfn_to_pfn_async Paolo Bonzini
2015-05-08 11:20 ` [PATCH 02/12] KVM: x86: introduce num_emulated_msrs Paolo Bonzini
2015-05-08 11:20 ` [PATCH 03/12] KVM: remove unnecessary arg from mark_page_dirty_in_slot, export it Paolo Bonzini
2015-05-08 11:20 ` [PATCH 04/12] KVM: x86: pass host_initiated to functions that read MSRs Paolo Bonzini
2015-05-08 11:20 ` [PATCH 05/12] KVM: x86: pass the whole hflags field to emulator and back Paolo Bonzini
2015-05-08 11:20 ` [PATCH 06/12] KVM: x86: API changes for SMM support Paolo Bonzini
2015-05-21 14:49   ` Radim Krčmář
2015-05-21 14:59     ` Paolo Bonzini
2015-05-21 16:26       ` Radim Krčmář
2015-05-21 21:21         ` Paolo Bonzini
2015-05-08 11:20 ` [PATCH 07/12] KVM: x86: stubs " Paolo Bonzini
2015-05-21 14:55   ` Radim Krčmář
2015-05-08 11:20 ` [PATCH 08/12] KVM: x86: save/load state on SMM switch Paolo Bonzini
2015-05-21 16:20   ` Radim Krčmář
2015-05-21 16:21     ` Paolo Bonzini
2015-05-21 16:33       ` Radim Krčmář
2015-05-21 20:24         ` Paolo Bonzini
2015-05-22 13:13           ` Radim Krčmář
2015-05-21 16:23     ` Paolo Bonzini
2015-05-21 17:00       ` Radim Krčmář
2015-05-21 21:21         ` Paolo Bonzini
2015-05-22 14:17           ` Radim Krčmář
2015-05-25 12:46             ` Paolo Bonzini
2015-05-08 11:20 ` [PATCH 09/12] KVM: x86: add vcpu-specific functions to read/write/translate GFNs Paolo Bonzini
2015-05-08 11:20 ` [PATCH 10/12] KVM: x86: add SMM to the MMU role Paolo Bonzini
2015-05-08 11:20 ` [PATCH 11/12] KVM: x86: add KVM_MEM_X86_SMRAM memory slot flag Paolo Bonzini
2015-05-26 18:45   ` Avi Kivity
2015-05-27  9:26     ` Paolo Bonzini
2015-05-08 11:20 ` [PATCH 12/12] KVM: x86: advertise KVM_CAP_X86_SMM Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431084034-8425-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bsd@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).