LKML Archive on
 help / color / Atom feed
From: Lucas Stach <>
To: Thomas Gleixner <>,
	Jason Cooper <>,
	Marc Zyngier <>
Cc: Stephen Warren <>,
	Thierry Reding <>,
	Alexandre Courbot <>,,
Subject: [PATCH] irqchip: tegra: fix wrong data being passed as the irqdomain chip data
Date: Sat,  9 May 2015 22:06:54 +0200
Message-ID: <> (raw)

The irq chip functions use the irq chipdata directly as the base register
address of the controller, so this should be passed in instead of a pointer
to the array address holding the base address.

This fixes Tegra20 CPUidle as now the un-/masking of IRQs at the LIC level
works again, but more importantly it fixes the resulting memory corruption.

Signed-off-by: Lucas Stach <>
This is an important fix and should go into 4.1.
 drivers/irqchip/irq-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index 51c485d..f67bbd8 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -264,7 +264,7 @@ static int tegra_ictlr_domain_alloc(struct irq_domain *domain,
 		irq_domain_set_hwirq_and_chip(domain, virq + i, hwirq + i,
-					      &info->base[ictlr]);
+					      info->base[ictlr]);
 	parent_args = *args;

             reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 20:06 Lucas Stach [this message]
2015-05-13  8:48 ` [tip:irq/urgent] irqchip: tegra: Set the proper base address in irq " tip-bot for Lucas Stach
2015-05-13  9:35 ` [PATCH] irqchip: tegra: fix wrong data being passed as the irqdomain " Thierry Reding
2015-05-13 22:18 ` Stephen Warren

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone