From: Mike Kravetz <mike.kravetz@oracle.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Davidlohr Bueso <dave@stgolabs.net>,
David Rientjes <rientjes@google.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: [PATCH 1/2] mm/hugetlb: compute/return the number of regions added by region_add()
Date: Mon, 18 May 2015 10:49:08 -0700 [thread overview]
Message-ID: <1431971349-6668-2-git-send-email-mike.kravetz@oracle.com> (raw)
In-Reply-To: <1431971349-6668-1-git-send-email-mike.kravetz@oracle.com>
Modify region_add() to keep track of regions(pages) added to the
reserve map and return this value. The return value can be
compared to the return value of region_chg() to determine if the
map was modified between calls. Make vma_commit_reservation()
also pass along the return value of region_add(). The special
case return values of vma_needs_reservation() should also be
taken into account when determining the return value of
vma_commit_reservation().
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
---
mm/hugetlb.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index c41b2a0..7f64034 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -156,6 +156,7 @@ static long region_add(struct resv_map *resv, long f, long t)
{
struct list_head *head = &resv->regions;
struct file_region *rg, *nrg, *trg;
+ long chg = 0;
spin_lock(&resv->lock);
/* Locate the region we are either in or before. */
@@ -181,14 +182,17 @@ static long region_add(struct resv_map *resv, long f, long t)
if (rg->to > t)
t = rg->to;
if (rg != nrg) {
+ chg -= (rg->to - rg->from);
list_del(&rg->link);
kfree(rg);
}
}
+ chg += (nrg->from - f);
nrg->from = f;
+ chg += t - nrg->to;
nrg->to = t;
spin_unlock(&resv->lock);
- return 0;
+ return chg;
}
static long region_chg(struct resv_map *resv, long f, long t)
@@ -1349,18 +1353,25 @@ static long vma_needs_reservation(struct hstate *h,
else
return chg < 0 ? chg : 0;
}
-static void vma_commit_reservation(struct hstate *h,
+
+static long vma_commit_reservation(struct hstate *h,
struct vm_area_struct *vma, unsigned long addr)
{
struct resv_map *resv;
pgoff_t idx;
+ long add;
resv = vma_resv_map(vma);
if (!resv)
- return;
+ return 1;
idx = vma_hugecache_offset(h, vma, addr);
- region_add(resv, idx, idx + 1);
+ add = region_add(resv, idx, idx + 1);
+
+ if (vma->vm_flags & VM_MAYSHARE)
+ return add;
+ else
+ return 0;
}
static struct page *alloc_huge_page(struct vm_area_struct *vma,
--
2.1.0
next prev parent reply other threads:[~2015-05-18 17:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 17:49 [PATCH 0/2] alloc_huge_page/hugetlb_reserve_pages race Mike Kravetz
2015-05-18 17:49 ` Mike Kravetz [this message]
2015-05-21 23:30 ` [PATCH 1/2] mm/hugetlb: compute/return the number of regions added by region_add() Andrew Morton
2015-05-21 23:43 ` Mike Kravetz
2015-05-18 17:49 ` [PATCH 2/2] mm/hugetlb: handle races in alloc_huge_page and hugetlb_reserve_pages Mike Kravetz
2015-05-21 23:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431971349-6668-2-git-send-email-mike.kravetz@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).