From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753813AbbESGrG (ORCPT ); Tue, 19 May 2015 02:47:06 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:52265 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbbESGrD (ORCPT ); Tue, 19 May 2015 02:47:03 -0400 Message-ID: <1432018018.3277.22.camel@infradead.org> Subject: Re: mod_devicetable: Make dmi_strmatch.substr const char * From: David Woodhouse To: Joe Perches Cc: Rusty Russell , LKML , Quentin Casasnovas Date: Tue, 19 May 2015 07:46:58 +0100 In-Reply-To: <1431994055.2870.102.camel@perches.com> References: <1431994055.2870.102.camel@perches.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-05-18 at 17:07 -0700, Joe Perches wrote: > > changed dmi_strmatch.substr from char * to char[79]; > > Changing it back to const char * would shrink an x86-64 > defconfig more than 100KB. > > $ size vmlinux.old vmlinux.new > text data bss dec hex filename > 11941725 1825624 1085440 14852789 e2a2b5 vmlinux.old > 11921172 1730648 1085440 14737260 e0df6c vmlinux.new > > modpost has changed a bit since 2008, is it's time to change it back? Does the match table stuff still work if you do that? I thought the point in changing to an array was to make the table extraction do the right thing because it can't follow pointers... -- dwmw2