From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753966AbbESHNQ (ORCPT ); Tue, 19 May 2015 03:13:16 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:17586 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621AbbESHNM (ORCPT ); Tue, 19 May 2015 03:13:12 -0400 X-AuditID: cbfec7f5-f794b6d000001495-77-555ae286791a From: Krzysztof Kozlowski To: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "H. Nikolaus Schaller" , Krzysztof Kozlowski Subject: [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent Date: Tue, 19 May 2015 16:13:00 +0900 Message-id: <1432019582-27612-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLJMWRmVeSWpSXmKPExsVy+t/xy7ptj6JCDRZe5raY9OQ9s8XElZOZ LX5s+8pk8fqFocXlXXPYLD73HmG0OL27xIHdY+esu+wea96fYvbYvELLY9OqTjaPvi2rGD0+ b5ILYIvisklJzcksSy3St0vgyrg3N6fgAWdF489HjA2MD9m7GDk5JARMJA692wlli0lcuLee rYuRi0NIYCmjxJ75DUwQzn9Gie0LdjGCVLEJGEtsXr4ErEpEYDejxISpy1lAEswC8RIPp+xg BbGFBQIkTm7bzgRiswioSkz6sQ1oBQcHr4C7xMYXCRDb5CROHpvMOoGRewEjwypG0dTS5ILi pPRcI73ixNzi0rx0veT83E2MkED5uoNx6TGrQ4wCHIxKPLwr/CJDhVgTy4orcw8xSnAwK4nw sl2KChXiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3PX+xAhgfTEktTs1NSC1CKYLBMHp1QDY1v7 zeWTde5E25/Zl+cgum7jua8J6r/vXhS6m3t72yHdU66yUgzL9vzb//xKtH7r+1fvN/Wx/rG9 qdl41kFGuHOhYprIBm2Jv7+EZnGs0LkycftMy88Guc9tU02Xpy+/lyhxcm37NfMX93+dyy8U vV9xKCrkisv3+nnHXh+IeqKa2PcgyWxHHJsSS3FGoqEWc1FxIgBLu8yZEAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Changes since v1: ================= 1. Patch 2: fix invalid member used for container_of(). 2. Patch 2: Replace WARN with pr_warn() in __power_supply_register() if parent is missing. Description: ============ This is an idea to fix issue in bq27x00 driver (and probably in others) reported by H. Nikolaus Schaller [0]. The fixes are marked RFC/RFT because: 1. I do not have bq27x00-like device. I confirmed this and tested on modified drivers (max77693, ACPI AC). These drivers are not impacted by the issue but one can easily adjust them to reproduce the problem. 2. The first uevent coming from power_supply_register() is now different because it won't contain device properties. I am not sure how this impacts userspace. Comments are welcomed. [0] https://lkml.org/lkml/2015/5/18/152 Best regards, Krzysztof Krzysztof Kozlowski (2): power_supply: Fix NULL pointer dereference during bq27x00_battery probe power_supply: Fix possible NULL pointer dereference on early uevent drivers/power/power_supply_core.c | 61 +++++++++++++++++++++++++++++++++++---- include/linux/power_supply.h | 1 + 2 files changed, 56 insertions(+), 6 deletions(-) -- 1.9.1