From: Paul Bolle <pebolle@tiscali.nl>
To: Yaniv Gardi <ygardi@codeaurora.org>
Cc: James.Bottomley@HansenPartnership.com, kishon@ti.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
gbroner@codeaurora.org, dovl@codeaurora.org,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <JBottomley@odin.com>
Subject: Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component
Date: Wed, 20 May 2015 10:22:35 +0200 [thread overview]
Message-ID: <1432110155.21715.45.camel@x220> (raw)
In-Reply-To: <1432106479.21715.33.camel@x220>
On Wed, 2015-05-20 at 09:21 +0200, Paul Bolle wrote:
> As far as I can see, in next-20150519, drivers/scsi/ufs/ufs-qcom.c lacks
> the required module specific boilerplate for this to be useful. Is that
> boilerplate added in another series?
I need to rephrase this. Let me try again.
As far as I can see, in next-20150519, drivers/scsi/ufs/ufs-qcom.c lacks
a MODULE_LICENSE() macro. Without that macro loading the module should
trigger a warning and taint the kernel, right?
By the way, as far as I can see, this (new) module can only be loaded
manually (or via scripts). Is that what people want?
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-05-20 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 13:47 [PATCH v1 0/3] fixing building errors and warnings when components Yaniv Gardi
2015-05-19 13:47 ` [PATCH v1 1/3] phy: qcom-ufs: fix build error when the driver is built as a module Yaniv Gardi
2015-05-20 8:14 ` Paul Bolle
2015-05-20 9:40 ` ygardi
2015-05-19 13:47 ` [PATCH v1 2/3] scsi: ufs-qcom: fix compilation warning if compiled " Yaniv Gardi
2015-05-20 8:29 ` Paul Bolle
2015-05-20 13:49 ` ygardi
2015-05-19 13:47 ` [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component Yaniv Gardi
2015-05-20 7:21 ` Paul Bolle
2015-05-20 8:22 ` Paul Bolle [this message]
2015-05-21 7:16 ` Paul Bolle
2015-05-21 10:09 ` ygardi
2015-05-21 10:14 ` Paul Bolle
2015-05-21 17:18 ` ygardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432110155.21715.45.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=JBottomley@odin.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dovl@codeaurora.org \
--cc=gbroner@codeaurora.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=santoshsy@gmail.com \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).