linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chanwoo Choi <cwchoi00@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: rogerq@ti.com, r.baldyga@samsung.com, peter.chen@freescale.com,
	kishon@ti.com, balbi@ti.com, iivanov@mm-sol.com,
	cw00.choi@samsung.com, myungjoo.ham@samsung.com
Subject: [PATCH v2 0/2] extcon: Inform the state of both ID and VBUS pin for USB
Date: Wed, 27 May 2015 21:15:08 +0900	[thread overview]
Message-ID: <1432728910-10761-1-git-send-email-cw00.choi@samsung.com> (raw)

Previously, I discussed how to inform the changed state of both ID
and VBUS pin for USB connector on patch-set[1].
[1] https://lkml.org/lkml/2015/4/2/310

So, this patch adds the extcon_set_cable_line_state() function to inform
the additional state of external connectors without additional register/
unregister functions. This function uses the existing notifier chain
which is registered by extcon_register_notifier() / extcon_register_interest().

The extcon_set_cable_line_state() can inform the new state of both
ID and VBUS pin state through extcon_set_cable_line_state().

For exmaple:
- On extcon-usb-gpio.c as extcon provider driver as following:
        static void usb_extcon_detect_cable(struct work_struct *work)
        {
                ...
                /* check ID and update cable state */
                id = gpiod_get_value_cansleep(info->id_gpiod);
                if (id) {
                        extcon_set_cable_state_(info->edev, EXTCON_USB_HOST, false);
                        extcon_set_cable_state_(info->edev, EXTCON_USB, true);

                        extcon_set_cable_line_state(info->edev, EXTCON_USB,
                                                        EXTCON_USB_ID_HIGH);
                } else {
                        extcon_set_cable_state_(info->edev, EXTCON_USB, false);
                        extcon_set_cable_state_(info->edev, EXTCON_USB_HOST, true);

                        extcon_set_cable_line_state(info->edev, EXTCON_USB,
                                                        EXTCON_USB_ID_LOW);
                }
        }

- On specific extcon consumder driver as following:
        static int xxx_probe(struct platform_device *pdev)
        {
                struct notifier_chain nh;

                nb.notifier_call = extcon_usb_notifier;
                ret = extcon_register_notifier(edev, EXTCON_USB, &nb);
                ...
        }

        static int extcon_usb_notifier(struct notifier_block *self,
                unsigned long event, void *ptr)
        {
                switch (event) {
                case EXTCON_DETACHED:
                        printk("USB is detached\n");
                        break;
                case EXTCON_ATTACHED:
                        printk("USB is attached\n");
                        break;

                case EXTCON_USB_ID_LOW:
                        printk("USB's ID pin is low state\n");
                        break;
                case EXTCON_USB_ID_HIGH:
                        printk("USB's ID pin is high state\n");
                        break;
                case EXTCON_USB_VBUS_LOW:
                        printk("USB's VBUS pin is high state\n");
                        break;
                case EXTCON_USB_VBUS_HIGH:
                        printk("USB's VBUS pin is high state\n");
                        break;
                default:
                        return -EINVAL;
                };
        }

Changes from v1:
- Use dev_warn() instead of dev_info() if set the same extcon_line_state value.

Chanwoo Choi (2):
  extcon: Add extcon_set_cable_line_state() to inform the additional state of external connectors
  extcon: usb-gpio: Update the ID pin state of USB when cable state is changed

 drivers/extcon/extcon-usb-gpio.c |  6 ++++
 drivers/extcon/extcon.c          | 74 +++++++++++++++++++++++++++++++++++++++-
 include/linux/extcon.h           | 24 +++++++++++++
 3 files changed, 103 insertions(+), 1 deletion(-)

-- 
2.2.0.GIT


             reply	other threads:[~2015-05-27 12:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 12:15 Chanwoo Choi [this message]
2015-05-27 12:15 ` [PATCH v2 1/2] extcon: Add extcon_set_cable_line_state() to inform the additional state of external connectors Chanwoo Choi
2015-05-27 14:38   ` Roger Quadros
2015-05-27 15:06     ` Chanwoo Choi
2015-05-28  9:02       ` Ivan T. Ivanov
     [not found]         ` <CAGTfZH2rn7OfqaTmr0d5-MfWW3ZFdt05_7vtLKqbEQee53999w@mail.gmail.com>
2015-05-28  9:37           ` Ivan T. Ivanov
2015-05-29  7:58             ` Chanwoo Choi
2015-05-27 12:15 ` [PATCH v2 2/2] extcon: usb-gpio: Update the ID pin state of USB when cable state is changed Chanwoo Choi
2015-05-27 14:40   ` Roger Quadros
2015-05-27 14:09 ` [PATCH v2 0/2] extcon: Inform the state of both ID and VBUS pin for USB Roger Quadros
2015-05-27 14:19   ` Chanwoo Choi
2015-05-28  8:45 ` Ivan T. Ivanov
2015-05-28 14:23   ` Roger Quadros
2015-05-29  1:22     ` Peter Chen
2015-05-29 10:53       ` Chanwoo Choi
2015-05-29 12:15         ` Chanwoo Choi
2015-06-02  6:51           ` Roger Quadros
2015-05-29  7:35     ` Ivan T. Ivanov
2015-05-29  7:36     ` Ivan T. Ivanov
2015-05-29 10:39     ` Chanwoo Choi
2015-05-29 10:44   ` Chanwoo Choi
2015-05-29 14:32     ` Ivan T. Ivanov
2015-05-29 17:15       ` Chanwoo Choi
2015-05-29 17:39         ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432728910-10761-1-git-send-email-cw00.choi@samsung.com \
    --to=cwchoi00@gmail.com \
    --cc=balbi@ti.com \
    --cc=cw00.choi@samsung.com \
    --cc=iivanov@mm-sol.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=peter.chen@freescale.com \
    --cc=r.baldyga@samsung.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).