From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753007AbbFAUIZ (ORCPT ); Mon, 1 Jun 2015 16:08:25 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:36351 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbbFAUIQ (ORCPT ); Mon, 1 Jun 2015 16:08:16 -0400 Message-ID: <1433197152.3615.4.camel@pedrito-laptop> Subject: Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null From: pmarzo To: Greg KH Cc: navyasri.tech@gmail.com, dilekuzulmez@gmail.com, joe@perches.com, haticeerturk27@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 02 Jun 2015 00:19:12 +0200 In-Reply-To: <20150531013900.GF28154@kroah.com> References: <1432167919-26298-1-git-send-email-marzo.pedro@gmail.com> <1432167919-26298-3-git-send-email-marzo.pedro@gmail.com> <20150531013900.GF28154@kroah.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote: > On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote: > > Remove two lines at ieee80211_wep_null which checkpatch.pl reported as errors. > > The first one because it has a C99 comment style and the second one because it is a void > > return which is useless. > > > > Signed-off-by: Pedro Marzo Perez > > --- > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > index bd789d1..94622cc 100644 > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > @@ -279,6 +279,4 @@ void __exit ieee80211_crypto_wep_exit(void) > > > > void ieee80211_wep_null(void) > > { > > -// printk("============>%s()\n", __func__); > > - return; > > } > > Please just delete the function. It is not so easy, the function is exported at file drivers/staging/rtl8192u/ieee80211/ieee80211.h and used at drivers/staging/rtl8192u/ieee80211/ieee80211_module.c line 179 with several other "null" functions, it seems a dirty trick to force module loading: /* These function were added to load crypte module autoly */ ieee80211_tkip_null(); ieee80211_wep_null(); ieee80211_ccmp_null(); I guess all this stuff should be rewritten to force the autoload properly but I don't have the knowledge to fix all this. Sorry Greg :-(