From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759206AbbFBNfU (ORCPT ); Tue, 2 Jun 2015 09:35:20 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:35304 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759158AbbFBNfO (ORCPT ); Tue, 2 Jun 2015 09:35:14 -0400 Message-ID: <1433252105.20244.3.camel@CEM14014B> Subject: Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null From: pmarzo To: Greg KH Cc: devel@driverdev.osuosl.org, haticeerturk27@gmail.com, linux-kernel@vger.kernel.org, joe@perches.com, dilekuzulmez@gmail.com, navyasri.tech@gmail.com Date: Tue, 02 Jun 2015 15:35:05 +0200 In-Reply-To: <20150602082555.GA2936@kroah.com> References: <1432167919-26298-1-git-send-email-marzo.pedro@gmail.com> <1432167919-26298-3-git-send-email-marzo.pedro@gmail.com> <20150531013900.GF28154@kroah.com> <1433197152.3615.4.camel@pedrito-laptop> <20150602052137.GA22211@kroah.com> <1433232499.2575.4.camel@CEM14014B> <20150602082555.GA2936@kroah.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On mar, 2015-06-02 at 17:25 +0900, Greg KH wrote: > On Tue, Jun 02, 2015 at 10:08:19AM +0200, pmarzo wrote: > > On mar, 2015-06-02 at 14:21 +0900, Greg KH wrote: > > > On Tue, Jun 02, 2015 at 12:19:12AM +0200, pmarzo wrote: > > > > On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote: > > > > > On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote: > > > > > > Remove two lines at ieee80211_wep_null which checkpatch.pl reported as errors. > > > > > > The first one because it has a C99 comment style and the second one because it is a void > > > > > > return which is useless. > > > > > > > > > > > > Signed-off-by: Pedro Marzo Perez > > > > > > --- > > > > > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 2 -- > > > > > > 1 file changed, 2 deletions(-) > > > > > > > > > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > > > > > index bd789d1..94622cc 100644 > > > > > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > > > > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > > > > > @@ -279,6 +279,4 @@ void __exit ieee80211_crypto_wep_exit(void) > > > > > > > > > > > > void ieee80211_wep_null(void) > > > > > > { > > > > > > -// printk("============>%s()\n", __func__); > > > > > > - return; > > > > > > } > > > > > > > > > > Please just delete the function. > > > > > > > > It is not so easy, the function is exported at file > > > > drivers/staging/rtl8192u/ieee80211/ieee80211.h and used at > > > > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c line 179 with > > > > several other "null" functions, it seems a dirty trick to force module > > > > loading: > > > > /* These function were added to load crypte module autoly */ > > > > ieee80211_tkip_null(); > > > > ieee80211_wep_null(); > > > > ieee80211_ccmp_null(); > > > > > > > > I guess all this stuff should be rewritten to force the autoload > > > > properly but I don't have the knowledge to fix all this. > > > > Sorry Greg :-( > > > > > > Ugh, that's a mess. Ok, I'll take this patch again, please resend it. > > > > > > thanks, > > > > > > greg k-h > > > > > > > > Ok, no problem, just not sure what do I have to resend. > > > > Should I resend the whole serie of three patches 1/3 2/3 3/3? > > I received an e-mail confirming the acceptance of patch 3/3 on your > > staging tree, no news about patch 1/3 yet, so it may confuse you if I > > resend all of them. > > Resend whatever I have not yet applied. > > thanks, > > greg k-h Ok, I will download your staging tree and regenerate patches 1/3 and 2/3 with that git tree. That would be v5 1/2 and 2/2 new patches. Just one (probably very stupid) question, why do you need me to resend the patches? I mean, both of them apply cleanly to your staging tree with patch 3/3 already merged. regards, Pedro.