From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753470AbbFLKvg (ORCPT ); Fri, 12 Jun 2015 06:51:36 -0400 Received: from ozlabs.org ([103.22.144.67]:38310 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257AbbFLKvc (ORCPT ); Fri, 12 Jun 2015 06:51:32 -0400 Message-ID: <1434106289.20648.2.camel@ellerman.id.au> Subject: linux-next: build failure after merge of the tip tree From: Michael Ellerman To: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , "David S.Miller" Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, derek.chickles@caviumnetworks.com, satananda.burla@caviumnetworks.com, felix.manlunas@caviumnetworks.com, Robert.Richter@caviumnetworks.com, Aleksey.Makarov@caviumnetworks.com, raghu.vatsavayi@caviumnetworks.com Date: Fri, 12 Jun 2015 20:51:29 +1000 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, After merging the tip tree, today's linux-next build (x86_allmodconfig) failed like this: drivers/net/ethernet/cavium/liquidio/request_manager.c: In function 'octeon_init_instr_queue': drivers/net/ethernet/cavium/liquidio/request_manager.c:111:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration] iq->request_list = vmalloc(sizeof(*iq->request_list) * num_descs); ^ drivers/net/ethernet/cavium/liquidio/request_manager.c: In function 'octeon_delete_instr_queue': drivers/net/ethernet/cavium/liquidio/request_manager.c:178:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(iq->request_list); ^ drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function 'octeon_free_device_mem': drivers/net/ethernet/cavium/liquidio/octeon_device.c:653:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(oct->droq[i]); ^ And so on. Caused by the interaction of commit d6472302f242 "x86/mm: Decouple from " from the tip tree with commit f21fb3ed364b "Add support of Cavium Liquidio ethernet adapters" from the net-next tree. I applied the following fix for today: diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c index 2ca91657295f..4e581facae2c 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c @@ -27,6 +27,7 @@ #include #include #include +#include #include "octeon_config.h" #include "liquidio_common.h" #include "octeon_droq.h" diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c index 60a186f1609b..94b502a0cf33 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c @@ -25,6 +25,7 @@ #include #include #include +#include #include "octeon_config.h" #include "liquidio_common.h" #include "octeon_droq.h" diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c index adb428463495..cd58660dd161 100644 --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c +++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c @@ -26,6 +26,7 @@ #include #include #include +#include #include "octeon_config.h" #include "liquidio_common.h" #include "octeon_droq.h" cheers