From: Paul Bolle <pebolle@tiscali.nl>
To: Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: kernel@stlinux.com, rjw@rjwysocki.net, viresh.kumar@linaro.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
ajitpal.singh@st.com
Subject: Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms
Date: Tue, 23 Jun 2015 10:00:11 +0200 [thread overview]
Message-ID: <1435046411.4528.6.camel@tiscali.nl> (raw)
In-Reply-To: <1434987837-24212-8-git-send-email-lee.jones@linaro.org>
On Mon, 2015-06-22 at 16:43 +0100, Lee Jones wrote:
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> +config ARM_ST_CPUFREQ
> +> > bool "ST CPUFreq support"
> +> > depends on SOC_STIH407
> +> > help
> +> > OPP list for cpufreq-dt driver can be provided through DT or can be
> +> > created at runtime. Select this if you want create OPP list at runtime.
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> +obj-$(CONFIG_ARM_ST_CPUFREQ) += st-cpufreq.o
> --- /dev/null
> +++ b/drivers/cpufreq/st-cpufreq.c
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> +#include <linux/module.h>
> +MODULE_DEVICE_TABLE(of, sti_cpufreq_of_match);
>
> +module_platform_driver(sti_cpufreq);
>
> +MODULE_AUTHOR("Ajitpal Singh <ajitpal.singh@st.com>");
> +MODULE_DESCRIPTION("Creates an OPP list for cpufreq-cpu0 at runtime");
> +MODULE_LICENSE("GPL v2");
(There's a mismatch between the license used in the comment at the top
of this file and the ident used in the MODULE_LICENSE() macro. See
include/linux/module.h.)
st-cpufreq.o can only be built-in. But the code contains of few lines
that are only useful if the code can be modular. Was ARM_ST_CPUFREQ
perhaps meant to be tristate?
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-06-23 8:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 15:43 [PATCH 0/8] cpufreq: Introduce support for ST's cpufreq functionality Lee Jones
2015-06-22 15:43 ` [PATCH 1/8] ARM: STi: STiH407: Provide generic (safe) DVFS configuration Lee Jones
2015-06-22 15:43 ` [PATCH 2/8] ARM: STi: STiH407: Provide CPU with clocking information Lee Jones
2015-06-22 15:43 ` [PATCH 3/8] ARM: STi: STiH407: Link CPU with its voltage supply Lee Jones
2015-06-22 15:43 ` [PATCH 4/8] ARM: STi: STiH407: Provide a node for CPUFreq Lee Jones
2015-06-23 2:16 ` Viresh Kumar
2015-06-23 7:10 ` Lee Jones
2015-06-23 7:57 ` Viresh Kumar
2015-06-22 15:43 ` [PATCH 5/8] ARM: STi: STiH407: Move PWM nodes STiH407 => STiH407-family Lee Jones
2015-06-23 2:17 ` Viresh Kumar
2015-06-23 7:08 ` Lee Jones
2015-06-23 7:55 ` Viresh Kumar
2015-06-22 15:43 ` [PATCH 6/8] ARM: multi_v7_defconfig: Enable support for PWM Regulators Lee Jones
2015-06-22 15:43 ` [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms Lee Jones
2015-06-23 2:50 ` Viresh Kumar
2015-06-23 7:16 ` Lee Jones
2015-06-23 7:31 ` [STLinux Kernel] " Maxime Coquelin
2015-06-23 8:03 ` Viresh Kumar
2015-06-23 8:27 ` Lee Jones
2015-06-23 8:30 ` Viresh Kumar
2015-06-23 9:00 ` Lee Jones
2015-06-23 8:00 ` Paul Bolle [this message]
2015-06-23 8:28 ` Lee Jones
2015-06-23 20:03 ` Paul Bolle
2015-06-24 7:33 ` Lee Jones
2015-06-22 15:43 ` [PATCH 8/8] dt: cpufreq: st: Provide bindings for ST's CPUFreq implementation Lee Jones
2015-06-23 2:34 ` Viresh Kumar
2015-06-23 7:06 ` Lee Jones
2015-06-23 7:55 ` Viresh Kumar
2015-06-23 8:38 ` Lee Jones
2015-06-23 8:52 ` Javier Martinez Canillas
2015-06-23 8:59 ` Lee Jones
2015-06-23 9:00 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435046411.4528.6.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=ajitpal.singh@st.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).