From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751164AbbG1WHG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jul 2015 18:07:06 -0400
Received: from lb3-smtp-cloud3.xs4all.net ([194.109.24.30]:56364 "EHLO
	lb3-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750955AbbG1WHE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jul 2015 18:07:04 -0400
Message-ID: <1438121215.30903.27.camel@tiscali.nl>
Subject: Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP
From: Paul Bolle <pebolle@tiscali.nl>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@stlinux.com, jassisinghbrar@gmail.com,
        devicetree@vger.kernel.org
Date: Wed, 29 Jul 2015 00:06:55 +0200
In-Reply-To: <1437990272-23111-4-git-send-email-lee.jones@linaro.org>
References: <1437990272-23111-1-git-send-email-lee.jones@linaro.org>
	 <1437990272-23111-4-git-send-email-lee.jones@linaro.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.4 (3.16.4-2.fc22) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On ma, 2015-07-27 at 10:44 +0100, Lee Jones wrote:
> --- /dev/null
> +++ b/drivers/mailbox/mailbox-sti.c

> +static int sti_mbox_probe(struct platform_device *pdev)
> +{
> +	[...]
> +
> +	match = of_match_device(sti_mailbox_match, &pdev->dev);
> +	if (!match) {
> +		dev_err(&pdev->dev, "No configuration found\n");
> +		return -ENODEV;
> +	}
> +	pdev->dev.platform_data = (struct sti_mbox_pdata *) match->data;
> +
> +	[...]
> +}

> +static struct platform_driver sti_mbox_driver = {
> +	.probe = sti_mbox_probe,
> +	.remove = sti_mbox_remove,
> +	.driver = {
> +		.name = "sti-mailbox",
> +		.of_match_table = sti_mailbox_match,
> +	},
> +};
> +module_platform_driver(sti_mbox_driver);

> +MODULE_ALIAS("platform:mailbox-sti");

It seems this alias is only useful if there's a corresponding struct
platform_device with a "mailbox-sti" .name. I couldn't spot that
platform_device.

Besides, if I read sti_max_probe() correctly, without OF support loading
this module won't accomplish much. So what would another way of
autoloading this module buy you?

Thanks,


Paul Bolle