From: Lucas Stach <l.stach@pengutronix.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Thierry Reding <treding@nvidia.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm: bridge/dw_hdmi: Cache edid data
Date: Fri, 07 Aug 2015 16:20:47 +0200 [thread overview]
Message-ID: <1438957247.2467.17.camel@pengutronix.de> (raw)
In-Reply-To: <20150807141346.GH7557@n2100.arm.linux.org.uk>
Am Freitag, den 07.08.2015, 15:13 +0100 schrieb Russell King - ARM
Linux:
> On Fri, Aug 07, 2015 at 03:59:20PM +0200, Sascha Hauer wrote:
> > Instead of rereading the edid data each time userspace asks for them
> > read them once and cache them in the previously unused edid field in
> > struct dw_hdmi. This makes the code a little bit more efficient.
>
> How has this been tested?
>
> Has it been tested with an AV amplifier in the path to the display device?
> If not, it really needs to be tested, because such devices modify the EDID
> data, or subsitute their own, and alter the EDID data depending on their
> needs. When they do, they lower and re-assert the HPD signal, possibly
> for as little as 100ms - defined by the HDMI spec.
>
This has not been tested with an AV amp, but if the amp behaves the way
you describe it this should be fine.
If we get an HPD event we inform the DRM core, which will then call our
connector detect function, triggering a re-read of the EDID data.
Regards,
Lucas
> For example, an AV amplifier in standby can provide the displays EDID in
> the first page of EDID, along with the displays extended EDID in the
> second page. When the AV amplifier is powered up, it can provide a
> different second page of EDID information detailing the audio formats
> that it can accept, and it will lower and re-assert the HPD signal to
> cause the connected devices to read the updated EDID information. Same
> thing can happen when switching to standby mode too.
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-08-07 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 13:59 drm: bridge/dw_hdmi patches Sascha Hauer
2015-08-07 13:59 ` [PATCH 1/2] drm: bridge/dw_hdmi: Cache edid data Sascha Hauer
2015-08-07 14:13 ` Russell King - ARM Linux
2015-08-07 14:20 ` Lucas Stach [this message]
2015-08-07 22:40 ` Russell King - ARM Linux
2015-08-08 13:35 ` Russell King - ARM Linux
2015-08-08 15:13 ` Russell King - ARM Linux
2015-08-07 13:59 ` [PATCH 2/2] drm: bridge/dw_hdmi: remove unused code Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438957247.2467.17.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).