From: Joe Perches <joe@perches.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>,
"sparse@chrisli.org" <sparse@chrisli.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: false positives with checkpatch
Date: Fri, 07 Aug 2015 08:37:47 -0700 [thread overview]
Message-ID: <1438961867.2322.43.camel@perches.com> (raw)
In-Reply-To: <1438959684.17630.4.camel@linux.intel.com>
On Fri, 2015-08-07 at 09:01 -0600, Ross Zwisler wrote:
> When running checkpatch.pl against my latest patch set, I hit what I think are
> two false positives. Here are the related lines:
>
> +static inline void flush_cache_pmem(void __pmem *addr, size_t size)
> +{
> + if (arch_has_pmem_api())
> + arch_flush_cache_pmem(addr, size);
> +}
>
> The error was:
>
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #88: FILE: include/linux/pmem.h:167:
> +static inline void flush_cache_pmem(void __pmem *addr, size_t size)
> ^
> The (void __annotation *variable) syntax is correct, I believe, and is used
> consistently for both __iomem and __pmem annotations.
checkpatch doesn't know what a __pmem is.
Neither did I until a second ago.
Are there any other sparse annotations that were
added by this subsystem? (I don't notice any)
They need to be added to checkpatch's $Sparse use
so there's a patch proposal below this.
It looks like compiler.h's #define __safe is unused
in the linux kernel and it could be deleted as it's
not a gcc attribute.
Does anyone know?
Linus' commit is unrevealing.
commit e6b8f25bd950947d06c59432cbafd320dda66abf
Author: Linus Torvalds <torvalds@evo.osdl.org>
Date: Fri Apr 16 03:49:32 2004 -0700
Add sparse __safe annotation
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index fd8e502..6362ec3 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -264,6 +264,7 @@ our $Sparse = qr{
__kernel|
__force|
__iomem|
+ __pmem|
__must_check|
__init_refok|
__kprobes|
next parent reply other threads:[~2015-08-07 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1438959684.17630.4.camel@linux.intel.com>
2015-08-07 15:37 ` Joe Perches [this message]
2015-08-07 16:12 ` false positives with checkpatch Andy Whitcroft
2015-08-07 18:07 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438961867.2322.43.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).