From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: linux-leds@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, cooloney@gmail.com,
rpurdie@rpsys.net, stsp@users.sourceforge.net,
Andrew Lunn <andrew@lunn.ch>,
Jacek Anaszewski <j.anaszewski@samsung.com>
Subject: [PATCH/RFC v5 32/57] leds: mc13783: Remove work queue
Date: Tue, 11 Aug 2015 11:37:45 +0200 [thread overview]
Message-ID: <1439285890-27329-33-git-send-email-j.anaszewski@samsung.com> (raw)
In-Reply-To: <1439285890-27329-1-git-send-email-j.anaszewski@samsung.com>
From: Andrew Lunn <andrew@lunn.ch>
Now the core implements the work queue, remove it from the drivers.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
drivers/leds/leds-mc13783.c | 32 ++++++++------------------------
1 file changed, 8 insertions(+), 24 deletions(-)
diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
index e2b847f..17909dd 100644
--- a/drivers/leds/leds-mc13783.c
+++ b/drivers/leds/leds-mc13783.c
@@ -20,7 +20,6 @@
#include <linux/platform_device.h>
#include <linux/leds.h>
#include <linux/of.h>
-#include <linux/workqueue.h>
#include <linux/mfd/mc13xxx.h>
struct mc13xxx_led_devtype {
@@ -32,8 +31,6 @@ struct mc13xxx_led_devtype {
struct mc13xxx_led {
struct led_classdev cdev;
- struct work_struct work;
- enum led_brightness new_brightness;
int id;
struct mc13xxx_leds *leds;
};
@@ -55,9 +52,11 @@ static unsigned int mc13xxx_max_brightness(int id)
return 0x3f;
}
-static void mc13xxx_led_work(struct work_struct *work)
+static void mc13xxx_led_set(struct led_classdev *led_cdev,
+ enum led_brightness value)
{
- struct mc13xxx_led *led = container_of(work, struct mc13xxx_led, work);
+ struct mc13xxx_led *led =
+ container_of(led_cdev, struct mc13xxx_led, cdev);
struct mc13xxx_leds *leds = led->leds;
unsigned int reg, bank, off, shift;
@@ -107,17 +106,7 @@ static void mc13xxx_led_work(struct work_struct *work)
mc13xxx_reg_rmw(leds->master, leds->devtype->ledctrl_base + reg,
mc13xxx_max_brightness(led->id) << shift,
- led->new_brightness << shift);
-}
-
-static void mc13xxx_led_set(struct led_classdev *led_cdev,
- enum led_brightness value)
-{
- struct mc13xxx_led *led =
- container_of(led_cdev, struct mc13xxx_led, cdev);
-
- led->new_brightness = value;
- schedule_work(&led->work);
+ value << shift);
}
#ifdef CONFIG_OF
@@ -259,8 +248,7 @@ static int __init mc13xxx_led_probe(struct platform_device *pdev)
leds->led[i].cdev.flags = LED_CORE_SUSPENDRESUME;
leds->led[i].cdev.brightness_set = mc13xxx_led_set;
leds->led[i].cdev.max_brightness = mc13xxx_max_brightness(id);
-
- INIT_WORK(&leds->led[i].work, mc13xxx_led_work);
+ leds->led[i].cdev.flags |= LED_BRIGHTNESS_BLOCKING;
ret = led_classdev_register(dev->parent, &leds->led[i].cdev);
if (ret) {
@@ -270,10 +258,8 @@ static int __init mc13xxx_led_probe(struct platform_device *pdev)
}
if (ret)
- while (--i >= 0) {
+ while (--i >= 0)
led_classdev_unregister(&leds->led[i].cdev);
- cancel_work_sync(&leds->led[i].work);
- }
return ret;
}
@@ -283,10 +269,8 @@ static int mc13xxx_led_remove(struct platform_device *pdev)
struct mc13xxx_leds *leds = platform_get_drvdata(pdev);
int i;
- for (i = 0; i < leds->num_leds; i++) {
+ for (i = 0; i < leds->num_leds; i++)
led_classdev_unregister(&leds->led[i].cdev);
- cancel_work_sync(&leds->led[i].work);
- }
return 0;
}
--
1.7.9.5
next prev parent reply other threads:[~2015-08-11 9:47 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 9:37 [PATCH/RFC v5 00/57] Remove work queues from LED class drivers Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 01/57] leds: Add brightness_set_nonblocking op Jacek Anaszewski
2015-08-13 14:15 ` Andrew Lunn
2015-08-13 14:23 ` Pavel Machek
2015-08-14 7:57 ` Jacek Anaszewski
2015-08-19 14:03 ` Jacek Anaszewski
2015-08-19 14:09 ` Andrew Lunn
2015-08-19 19:31 ` Pavel Machek
2015-08-11 9:37 ` [PATCH/RFC v5 02/57] leds: Add LED_BRIGHTNESS_BLOCKING flag Jacek Anaszewski
2015-08-13 14:05 ` Andrew Lunn
2015-08-11 9:37 ` [PATCH/RFC v5 03/57] leds: Add led_set_brightness_sync to the public LED subsystem API Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 04/57] leds: Improve asynchronous path of setting brightness Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 05/57] leds: Add an internal led_set_brightness_nosleep function Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 06/57] leds: Improve setting brightness in a non sleeping way Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 07/57] leds: Drivers shouldn't enforce SYNC/ASYNC brightness setting Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 08/57] leds: ktd2692: Remove work queue Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 09/57] leds: aat1290: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 10/57] leds: max77693: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 11/57] Documentation: leds: Add description of brightness_set* ops Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 12/57] leds: tlc591xx: Remove work queue Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 13/57] leds: 88pm860x: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 14/57] leds: adp5520: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 15/57] leds: bd2802: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 16/57] leds: blinkm: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 17/57] leds: lm3533: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 18/57] leds: lm3642: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 19/57] leds: pca9532: Remove work queue for LEDs Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 20/57] leds: lp3944: Remove work queue Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 21/57] leds: lp55xx: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 22/57] leds: lp8788: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 23/57] leds: lp8860: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 24/57] leds: pca955x: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 25/57] leds: pca963x: " Jacek Anaszewski
2015-08-11 9:42 ` Peter Meerwald
2015-08-11 10:00 ` Ricardo Ribalda Delgado
2015-08-11 10:35 ` Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 26/57] leds: wm831x: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 27/57] leds: da903x: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 28/57] leds: da9052: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 29/57] leds: dac124d085: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 30/57] leds: lt3593: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 31/57] leds: max8997: Remove unneeded workqueue include Jacek Anaszewski
2015-08-11 9:37 ` Jacek Anaszewski [this message]
2015-08-11 9:37 ` [PATCH/RFC v5 33/57] leds: regulator: Remove work queue Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 34/57] leds: wm8350: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 35/57] leds: gpio: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 36/57] leds: pwm: remove " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 37/57] leds: lm355x: Remove " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 38/57] leds: cobalt-raq: Use brightness_set_nonblocking op Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 39/57] leds: bcm6328: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 40/57] leds: bcm6358: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 41/57] leds: syscon: " Jacek Anaszewski
2015-08-11 12:54 ` Linus Walleij
2015-08-11 9:37 ` [PATCH/RFC v5 42/57] leds: ot200: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 43/57] leds: s3c24xx: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 44/57] leds: ss4200: " Jacek Anaszewski
2015-08-11 9:37 ` [PATCH/RFC v5 45/57] leds: versatile: " Jacek Anaszewski
2015-08-11 12:55 ` Linus Walleij
2015-08-11 9:37 ` [PATCH/RFC v5 46/57] leds: wrap: " Jacek Anaszewski
2015-08-11 9:38 ` [PATCH/RFC v5 47/57] leds: net48xx: " Jacek Anaszewski
2015-08-11 9:38 ` [PATCH/RFC v5 48/57] leds: asic3: " Jacek Anaszewski
2015-08-11 9:38 ` [PATCH/RFC v5 49/57] leds: cobalt-qube: " Jacek Anaszewski
2015-08-11 9:38 ` [PATCH/RFC v5 50/57] leds: fsg: " Jacek Anaszewski
2015-08-11 9:38 ` [PATCH/RFC v5 51/57] leds: hp6xx: " Jacek Anaszewski
2015-08-11 9:38 ` [PATCH/RFC v5 52/57] leds: locomo: " Jacek Anaszewski
2015-08-11 9:38 ` [PATCH/RFC v5 53/57] leds: dell: " Jacek Anaszewski
2015-08-11 9:38 ` [PATCH/RFC v5 54/57] leds: rb532: " Jacek Anaszewski
2015-08-11 9:38 ` [PATCH/RFC v5 55/57] leds: sunfire: " Jacek Anaszewski
2015-08-11 17:27 ` David Miller
2015-08-11 9:38 ` [PATCH/RFC v5 56/57] leds: ipaq-micro: Set LED_BRIGHTNESS_BLOCKING flag Jacek Anaszewski
2015-08-11 12:55 ` Linus Walleij
2015-08-11 9:38 ` [PATCH/RFC v5 57/57] leds: clevo-mail: " Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439285890-27329-33-git-send-email-j.anaszewski@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=andrew@lunn.ch \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=stsp@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).