From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753174AbbHMOlA (ORCPT <rfc822;w@1wt.eu>);
	Thu, 13 Aug 2015 10:41:00 -0400
Received: from mail-pa0-f50.google.com ([209.85.220.50]:35125 "EHLO
	mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753073AbbHMOk6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 13 Aug 2015 10:40:58 -0400
Message-ID: <1439476856.7960.8.camel@edumazet-glaptop2.roam.corp.google.com>
Subject: Re: [PATCH] mm: make page pfmemalloc check more robust
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: mhocko@kernel.org, linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>,
        Jiri Bohac <jbohac@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
        "David S. Miller" <davem@davemloft.net>,
        LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org,
        Michal Hocko <mhocko@suse.com>
Date: Thu, 13 Aug 2015 07:40:56 -0700
In-Reply-To: <55CC5FA0.300@suse.cz>
References: <1439456364-4530-1-git-send-email-mhocko@kernel.org>
	 <55CC5FA0.300@suse.cz>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-08-13 at 11:13 +0200, Vlastimil Babka wrote:

> Given that this apparently isn't the first case of this localhost issue, 
> I wonder if network code should just clear skb->pfmemalloc during send 
> (or maybe just send over localhost). That would be probably easier than 
> distinguish the __skb_fill_page_desc() callers for send vs receive.

Would this still needed after this patch ?

It is sad we do not have a SNMP counter to at least count how often we
drop skb because pfmemalloc is set.

I'll provide such a patch.