From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andy Whitcroft <apw@canonical.com>,
Alexander Duyck <alexander.h.duyck@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ipv4: off-by-one in continuation handling in /proc/net/route
Date: Thu, 13 Aug 2015 08:10:58 -0700 [thread overview]
Message-ID: <1439478658.7960.10.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1439461267-10627-1-git-send-email-apw@canonical.com>
On Thu, 2015-08-13 at 11:21 +0100, Andy Whitcroft wrote:
> When generating /proc/net/route we emit a header followed by a line for
> each route. When a short read is performed we will restart this process
> based on the open file descriptor. When calculating the start point we
> fail to take into account that the 0th entry is the header. This leads
> us to skip the first entry when doing a continuation read.
>
> This can be easily seen with the comparison below:
>
> while read l; do echo "$l"; done </proc/net/route >A
> cat /proc/net/route >B
> diff -bu A B | grep '^[+-]'
>
> On my example machine I have approximatly 10KB of route output. There we
> see the very first non-title element is lost in the while read case,
> and an entry around the 8K mark in the cat case:
>
> +wlan0 00000000 02021EAC 0003 0 0 400 00000000 0 0 0
> -tun1 00C0AC0A 00000000 0001 0 0 950 00C0FFFF 0 0 0
>
> Fix up the off-by-one when reaquiring position on continuation.
>
> BugLink: http://bugs.launchpad.net/bugs/1483440
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
> ---
> net/ipv4/fib_trie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> From code inspection I belive this was introduced by the Fixes
> below, but I have not tested this to confirm.
>
> Fixes: 8be33e955cb9 ("ipv4: off-by-one in continuation handling in /proc/net/route")
You probably meant
Fixes: 8be33e955cb9 ("fib_trie: Fib walk rcu should take a tnode and key instead of a trie and a leaf")
CC Alexander for review/comment
next prev parent reply other threads:[~2015-08-13 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 10:21 [PATCH 1/1] ipv4: off-by-one in continuation handling in /proc/net/route Andy Whitcroft
2015-08-13 15:10 ` Eric Dumazet [this message]
2015-08-13 16:07 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439478658.7960.10.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=alexander.h.duyck@redhat.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).