From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753524AbbHMRPW (ORCPT ); Thu, 13 Aug 2015 13:15:22 -0400 Received: from smtprelay0201.hostedemail.com ([216.40.44.201]:40906 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753473AbbHMRPU (ORCPT ); Thu, 13 Aug 2015 13:15:20 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:4250:4321:5007:6119:6261:7901:9707:10004:10400:10848:11026:11232:11658:11914:12296:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: blow40_1108b4b450b29 X-Filterd-Recvd-Size: 2223 Message-ID: <1439486115.27506.1.camel@perches.com> Subject: Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging From: Joe Perches To: plyatov@gmail.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, f.fainelli@gmail.com, luwei.zhou@freescale.com, richardcochran@gmail.com, davem@davemloft.net, u.kleine-koenig@pengutronix.de, Fabio.Estevam@freescale.com, LW@KARO-electronics.de, Frank.Li@freescale.com Date: Thu, 13 Aug 2015 10:15:15 -0700 In-Reply-To: <55CCCFDF.3090408@gmail.com> References: <1439471556-13760-1-git-send-email-plyatov@gmail.com> <1439484648.4818.13.camel@perches.com> <55CCCFDF.3090408@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-08-13 at 20:11 +0300, Igor Plyatov wrote: > > On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote: > >> * Due to HW bug, LAN8700 sometimes does not detect presence of energy in the > >> Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is > >> set, the ENERGYON bit does not asserted sometimes). This is a common bug of > >> LAN87xx family of PHY chips. > >> * The lan87xx_read_status() was improved to acquire ENERGYON bit. Its previous > >> algorythm still not reliable on 100 % and sometimes skip cable plugging. > > [] > >> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c > > [] > >> @@ -104,10 +104,12 @@ static int lan911x_config_init(struct phy_device *phydev) > >> static int lan87xx_read_status(struct phy_device *phydev) > >> { > >> int err = genphy_read_status(phydev); > >> + int rc; > > Is there a reason to move this declaration? > > There is no strict requirement to move declaration of the rc. > It was made just to have all declarations easily visible. Generally it's better to have declarations in the minimal/narrowest scope possible.