From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753488AbbHMRxM (ORCPT <rfc822;w@1wt.eu>);
	Thu, 13 Aug 2015 13:53:12 -0400
Received: from smtprelay0129.hostedemail.com ([216.40.44.129]:52174 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753139AbbHMRxK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 13 Aug 2015 13:53:10 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2896:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:4321:5007:6261:6742:7514:7576:8603:10004:10400:10848:11026:11232:11658:11914:12043:12438:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: sense47_3849065fb1e41
X-Filterd-Recvd-Size: 2056
Message-ID: <1439488385.27506.9.camel@perches.com>
Subject: Re: [PATCH v3] fs/pstore: provide panic data even in suspend
From: Joe Perches <joe@perches.com>
To: check.kernel@gmail.com
Cc: Petr Mladek <pmladek@suse.cz>, Alex Elder <elder@linaro.org>,
        Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>,
        Kees Cook <keescook@chromium.org>, Tony Luck <tony.luck@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Luis R. Rodriguez" <mcgrof@suse.com>,
        Peter Hurley <peter@hurleysoftware.com>, Tejun Heo <tj@kernel.org>,
        Ethan du <duhui@xiaomi.com>, Linghua Gu <gulinghua@xiaomi.com>,
        linux-kernel@vger.kernel.org, yangdongdong <yangdongdong@xiaomi.com>
Date: Thu, 13 Aug 2015 10:53:05 -0700
In-Reply-To: <1439351152-10836-1-git-send-email-check.kernel@gmail.com>
References: <1439351152-10836-1-git-send-email-check.kernel@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-08-12 at 11:45 +0800, check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>
> 
> If system restart after panic, this patch also enables
> panic and oops messages which in suspend context to be
> logged into ramoops console buffer where it can be read
> back at some later point.

trivia:

> diff --git a/include/linux/pstore_ram.h b/include/linux/pstore_ram.h
[]
> @@ -52,6 +52,7 @@ struct persistent_ram_zone {
>  	size_t old_log_size;
>  };
>  
> +extern void emergency_unlock_console(void);

None of the other function prototypes in this file use extern.
This one shouldn't either.

>  struct persistent_ram_zone *persistent_ram_new(phys_addr_t start, size_t size,
>  			u32 sig, struct persistent_ram_ecc_info *ecc_info,
>  			unsigned int memtype);