From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Gwendal Grignou <gwendal@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Wolfram Sang <wsa@the-dreams.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Olof Johansson <olof@lixom.net>,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers
Date: Wed, 19 Aug 2015 13:19:56 +0200 [thread overview]
Message-ID: <1439983198-4696-5-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1439983198-4696-1-git-send-email-javier@osg.samsung.com>
The ChromeOS EC SPI and I2C transport drivers depends on CROS_EC_PROTO
but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends
on is bad practice as it may lead to circular Kconfig dependencies.
Since these drivers already depend on MFD_CROS_EC and that config option
already selects CROS_EC_PROTO, there is no need to make them explicitly
depend on CROS_EC_PROTO since that dependency is already met.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mfd/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index feebc750aadf..99d63675f073 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -106,7 +106,7 @@ config MFD_CROS_EC
config MFD_CROS_EC_I2C
tristate "ChromeOS Embedded Controller (I2C)"
- depends on MFD_CROS_EC && CROS_EC_PROTO && I2C
+ depends on MFD_CROS_EC && I2C
help
If you say Y here, you get support for talking to the ChromeOS
@@ -116,7 +116,7 @@ config MFD_CROS_EC_I2C
config MFD_CROS_EC_SPI
tristate "ChromeOS Embedded Controller (SPI)"
- depends on MFD_CROS_EC && CROS_EC_PROTO && SPI
+ depends on MFD_CROS_EC && SPI
---help---
If you say Y here, you get support for talking to the ChromeOS EC
--
2.4.3
next prev parent reply other threads:[~2015-08-19 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 11:19 [PATCH 0/6] ChromeOS EC Kconfig cleanups Javier Martinez Canillas
2015-08-19 11:19 ` [PATCH 1/6] mfd: Add MFD_CROS_EC dependencies Javier Martinez Canillas
2015-08-19 13:00 ` Lee Jones
2015-08-19 11:19 ` [PATCH 2/6] Revert "platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM" Javier Martinez Canillas
2015-08-21 17:03 ` Olof Johansson
2015-08-19 11:19 ` [PATCH 3/6] platform/chrome: Make depends on MFD_CROS_EC instead CROS_EC_PROTO Javier Martinez Canillas
2015-08-21 17:03 ` Olof Johansson
2015-08-19 11:19 ` Javier Martinez Canillas [this message]
2015-08-19 12:59 ` [PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers Lee Jones
2015-08-19 11:19 ` [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency Javier Martinez Canillas
2015-08-24 12:18 ` Wolfram Sang
2015-08-19 11:19 ` [PATCH 6/6] Input: Replace KEYBOARD_CROS_EC dependency Javier Martinez Canillas
2015-08-19 21:26 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439983198-4696-5-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gwendal@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).