From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "emilne@redhat.com" <emilne@redhat.com>,
Christoph Hellwig <hch@lst.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check
Date: Wed, 26 Aug 2015 16:38:00 -0700 [thread overview]
Message-ID: <1440632280.2196.94.camel@HansenPartnership.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B3D42E9D0@hasmsx108.ger.corp.intel.com>
On Tue, 2015-08-25 at 21:03 +0000, Winkler, Tomas wrote:
>
> > > + /* this should never happen */
> > > + if (WARN_ON(!cmnd))
> > > + return SCSI_MLQUEUE_HOST_BUSY;
> > >
> > > - if (NULL == cmnd || NULL == devip) {
> > > - pr_warn("called with NULL cmnd or devip pointer\n");
> > > + if (NULL == devip) {
> > > + pr_warn("called devip == NULL\n");
> > > /* no particularly good error to report back */
> > > return SCSI_MLQUEUE_HOST_BUSY;
> > > }
> >
> > Please refer to the patch I just posted, we can't return _HOST_BUSY here
> > if devip == NULL. I posted a fix against the current "misc" branch as
> > I don't see this patch applied, let me know if I need to update it.
>
>
> I'm just not sure why the patches are not merged or even rejected.
Because ideally I want a Maintainer ack. That's Doug Gilbert.
> I'm submitting patches to the Linux kernel for more than 10 years to
> various trees and I can agree that these are not some urgent fixes,
> but this is the first time my effort is ignored for such long time by
> the maintainer.
Well, OK, I trust martin, I'll override the lack of Maintainer ack if
you fix as Ewan suggests.
James
> Thanks
> Tomas
>
> NrybXǧv^){.n+{"{ay\x1dʇڙ,j\afhz\x1ew\fj:+vwjm\azZ+ݢj"!
next prev parent reply other threads:[~2015-08-26 23:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 13:54 [scsi 1/7 RESEND] scsi_debug: define pr_fmt() for consistent logging Tomas Winkler
2015-07-28 13:54 ` [scsi 2/7 RESEND] scsi_debug: use SCSI_W_LUN_REPORT_LUNS instead of SAM2_WLUN_REPORT_LUNS; Tomas Winkler
2015-07-30 17:22 ` Martin K. Petersen
2015-07-28 13:54 ` [scsi 3/7 RESEND] scsi_debug: vfree is null safe so drop the check Tomas Winkler
2015-07-30 17:22 ` Martin K. Petersen
2015-07-28 13:54 ` [scsi 4/7 RESEND] scsi_debug: make dump_sector static Tomas Winkler
2015-07-30 17:22 ` Martin K. Petersen
2015-07-28 13:54 ` [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check Tomas Winkler
2015-07-30 17:23 ` Martin K. Petersen
2015-08-25 19:52 ` Ewan Milne
2015-08-25 21:03 ` Winkler, Tomas
2015-08-26 23:38 ` James Bottomley [this message]
2015-08-27 19:56 ` Ewan Milne
2015-08-30 10:36 ` Winkler, Tomas
2015-08-30 16:54 ` James Bottomley
2015-08-31 8:07 ` Winkler, Tomas
2015-07-28 13:54 ` [scsi 6/7 RESEND] scsi_debug: fix REPORT LUNS Well Known LU Tomas Winkler
2015-07-30 17:24 ` Martin K. Petersen
2015-07-28 13:54 ` [scsi 7/7] scsi_debug: resp_request: remove unused variable Tomas Winkler
2015-07-30 17:24 ` Martin K. Petersen
2015-07-30 17:21 ` [scsi 1/7 RESEND] scsi_debug: define pr_fmt() for consistent logging Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440632280.2196.94.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dgilbert@interlog.com \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).