From: Brian Gerst <brgerst@gmail.com>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH 6/7] x86/vdso32/xen: Move VDSO_NOTE_NONEGSEG_BIT define
Date: Sat, 29 Aug 2015 11:20:25 -0400 [thread overview]
Message-ID: <1440861626-27008-7-git-send-email-brgerst@gmail.com> (raw)
In-Reply-To: <1440861626-27008-1-git-send-email-brgerst@gmail.com>
Xen had its own vdso.h just to define VDSO_NOTE_NONEGSEG_BIT. Move it to the
main vdso.h.
Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
arch/x86/entry/vdso/vdso-note.S | 4 +---
arch/x86/include/asm/vdso.h | 9 +++++++++
arch/x86/xen/setup.c | 1 -
arch/x86/xen/vdso.h | 4 ----
4 files changed, 10 insertions(+), 8 deletions(-)
delete mode 100644 arch/x86/xen/vdso.h
diff --git a/arch/x86/entry/vdso/vdso-note.S b/arch/x86/entry/vdso/vdso-note.S
index eb8a6c7..34aa574 100644
--- a/arch/x86/entry/vdso/vdso-note.S
+++ b/arch/x86/entry/vdso/vdso-note.S
@@ -5,6 +5,7 @@
#include <linux/version.h>
#include <linux/elfnote.h>
+#include <asm/vdso.h>
/* Ideally this would use UTS_NAME, but using a quoted string here
doesn't work. Remember to change this when changing the
@@ -32,9 +33,6 @@ ELFNOTE_END
* if its bit is set in the mask word. So, we start with the mask 0, and
* at boot time we set VDSO_NOTE_NONEGSEG_BIT if running under Xen.
*/
-
-#include "../../xen/vdso.h" /* Defines VDSO_NOTE_NONEGSEG_BIT. */
-
ELFNOTE_START(GNU, 2, "a")
.long 1 /* ncaps */
VDSO32_NOTE_MASK: /* Symbol used by arch/x86/xen/setup.c */
diff --git a/arch/x86/include/asm/vdso.h b/arch/x86/include/asm/vdso.h
index 16d5c18..8d9a961 100644
--- a/arch/x86/include/asm/vdso.h
+++ b/arch/x86/include/asm/vdso.h
@@ -48,4 +48,13 @@ extern void __init init_vdso_image(const struct vdso_image *image);
#endif /* __ASSEMBLER__ */
+#if defined(CONFIG_X86_32) || defined(CONFIG_IA32_EMULATION)
+/*
+ * Bit used for the pseudo-hwcap for non-negative segments. We use
+ * bit 1 to avoid bugs in some versions of glibc when bit 0 is
+ * used; the choice is otherwise arbitrary.
+ */
+#define VDSO_NOTE_NONEGSEG_BIT 1
+#endif
+
#endif /* _ASM_X86_VDSO_H */
diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index b166ffd..79f9ed7 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -28,7 +28,6 @@
#include <xen/interface/physdev.h>
#include <xen/features.h>
#include "xen-ops.h"
-#include "vdso.h"
#include "p2m.h"
#include "mmu.h"
diff --git a/arch/x86/xen/vdso.h b/arch/x86/xen/vdso.h
deleted file mode 100644
index 861fedf..0000000
--- a/arch/x86/xen/vdso.h
+++ /dev/null
@@ -1,4 +0,0 @@
-/* Bit used for the pseudo-hwcap for non-negative segments. We use
- bit 1 to avoid bugs in some versions of glibc when bit 0 is
- used; the choice is otherwise arbitrary. */
-#define VDSO_NOTE_NONEGSEG_BIT 1
--
2.4.3
next prev parent reply other threads:[~2015-08-29 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 15:20 [PATCH 0/7] x86 vdso32 cleanups Brian Gerst
2015-08-29 15:20 ` [PATCH 1/7] x86/vdso32: Separate sigreturn code Brian Gerst
2015-08-29 15:20 ` [PATCH 2/7] x86/vdso32: Remove VDSO32_vsyscall_eh_frame_size Brian Gerst
2015-08-29 15:20 ` [PATCH 3/7] x86/vdso32: Remove unused vdso-fakesections.c Brian Gerst
2015-08-30 16:47 ` Andy Lutomirski
2015-08-29 15:20 ` [PATCH 4/7] x86/vdso32: Build single vdso32 image Brian Gerst
2015-08-29 15:20 ` [PATCH 5/7] x86/vdso: Merge 32-bit and 64-bit source files Brian Gerst
2015-08-29 15:20 ` Brian Gerst [this message]
2015-08-29 15:20 ` [PATCH 7/7] x86/vdso32: Remove vdso32 subdirectory Brian Gerst
2015-08-29 16:10 ` [PATCH 0/7] x86 vdso32 cleanups Andy Lutomirski
2015-08-30 21:18 ` Brian Gerst
2015-08-31 2:52 ` Andy Lutomirski
[not found] ` <CALCETrVdaDuSuLLByWbFsEei6LYaxZK6qFtJAHZhRu3ZqUc+RQ@mail.gmail.com>
2015-09-01 1:37 ` Andy Lutomirski
2015-09-01 21:50 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440861626-27008-7-git-send-email-brgerst@gmail.com \
--to=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).